From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YczZi-0001Rk-NB for qemu-devel@nongnu.org; Tue, 31 Mar 2015 13:03:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YczZd-0006ZA-Lh for qemu-devel@nongnu.org; Tue, 31 Mar 2015 13:03:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YczZd-0006Yy-DN for qemu-devel@nongnu.org; Tue, 31 Mar 2015 13:03:33 -0400 Message-ID: <551AD35F.2020509@redhat.com> Date: Tue, 31 Mar 2015 11:03:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427814871-1936-1-git-send-email-justin@quarantainenet.nl> <551AD0C9.6080507@redhat.com> In-Reply-To: <551AD0C9.6080507@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lP2kIdbNvg71tN2au5J5JJUiixsRu59AS" Subject: Re: [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Justin Ossevoort , qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lP2kIdbNvg71tN2au5J5JJUiixsRu59AS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/31/2015 10:52 AM, Paolo Bonzini wrote: >> -# Returns: Nothing. >> +# Returns: Number of bytes trimmed by this call. >=20 > It's better to add "(since 2.4)" here. >=20 > Apart from this, looks good. Changing a "return":{} to "return":0 is not backwards-compatible. >=20 > I'm CCing the qemu-ga maintainer. I failed to do that in my beefier reply, so I'm responding here just to say that this needs a v2. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lP2kIdbNvg71tN2au5J5JJUiixsRu59AS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVGtNfAAoJEKeha0olJ0NqVXgIAIst4UrQgFCHOIWz1WTBzHUt 9c0EmF7HHASX5nFTVMjjfP70b1OPoCadS7RVm5LFatCkUcgESmP3syzfS2lBAi8A bfQwuKPaMI9w0VBmPVXQPRrBo4nOaeTX7Swub1LzPQJDCKhA8jDzPF2mfbj8OfTo VvJkJK1uVKefg6TdqY+QCfIpOe6PKUWSLsGM7De8LUI+23MqqS4v2KQJZYbb253H p9umWRNO8BiG4pcriNFouJI2+sB7L4cJ3cPINleV+Nduk0ht7FdcbuJ5dVRZfQER o48sN7QieUW8V6yMXmPimcrpN8in2esTZsUQkPz6q7IcSyx3NhH90VJNIoVLlHQ= =BMbY -----END PGP SIGNATURE----- --lP2kIdbNvg71tN2au5J5JJUiixsRu59AS--