From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yd40k-00070d-Lf for qemu-devel@nongnu.org; Tue, 31 Mar 2015 17:47:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yd40f-00057T-Fl for qemu-devel@nongnu.org; Tue, 31 Mar 2015 17:47:50 -0400 Received: from s16892447.onlinehome-server.info ([82.165.15.123]:54299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yd40f-00056S-9n for qemu-devel@nongnu.org; Tue, 31 Mar 2015 17:47:45 -0400 Message-ID: <551B15EB.1080304@ilande.co.uk> Date: Tue, 31 Mar 2015 22:47:23 +0100 From: Mark Cave-Ayland MIME-Version: 1.0 References: <1427715918-25768-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1427715918-25768-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.3 0/3] ioport fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 30/03/15 12:45, Paolo Bonzini wrote: > These fix the problem with OpenBIOS's accesses to the VBE DISPI ports. > The problem stems from weird memory regions created by ioport.c. > > Patches 1-3 simplify some of the MemoryRegionPortio arrays. This makes it > easier to ascertain the effect of patch 6, since the patch only affects > MemoryRegionPortio entries whose size is greater than one. > > Patch 4 fixes a comment. ioport.c is crazy enough without wrong > documentation. > > The fix is in patch 6; however it makes it possible to trigger some > assertions in ioport.c so patch 5 is needed in order to loosen them. > > Peter, if you prefer you can just revert c3c1bb99. > > Paolo > > Paolo Bonzini (6): > sb16: remove useless mixer_write_indexw > gus: clean up MemoryRegionPortio > ide: there is only one data port > ioport: remove wrong comment > ioport: loosen assertions on emulation of 16-bit ports > ioport: reserve the whole range of an I/O port in the AddressSpace > > hw/audio/gus.c | 22 ++-------------------- > hw/audio/sb16.c | 7 ------- > hw/ide/core.c | 4 ++-- > ioport.c | 30 +++++++++++++++++------------- > 4 files changed, 21 insertions(+), 42 deletions(-) While I can't vouch for the effects outside of qemu-system-ppc and qemu-system-sparc64, I can confirm that this patch series fixes the VGA VBE register accesses in my testing here. Thanks Paolo! Tested-by: Mark Cave-Ayland ATB, Mark.