All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Ed Maste <emaste@freebsd.org>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns
Date: Tue, 31 Mar 2015 20:34:23 -0400	[thread overview]
Message-ID: <551B3D0F.5030206@redhat.com> (raw)
In-Reply-To: <CAPyFy2CSm4Bz-5xP+PNjY1kHJp_5mrCwE9FTDYNHgc=9DL95fQ@mail.gmail.com>



On 03/31/2015 08:29 PM, Ed Maste wrote:
> On 31 March 2015 at 17:55, Ed Maste <emaste@freebsd.org> wrote:
>>
>> feynman% ./tests/ahci-test
>> /i386/ahci/sanity: OK
>> /i386/ahci/pci_spec: OK
>> /i386/ahci/pci_enable: OK
>> /i386/ahci/hba_spec: OK
>> /i386/ahci/hba_enable: OK
>> /i386/ahci/identify: OK
>> /i386/ahci/io/pio/lba28/simple: **
>> ERROR:tests/ahci-test.c:790:ahci_test_io_rw_simple: assertion failed
>> (memcmp(tx, rx, bufsize) == 0): (0xffffffffffffffff == 0x00000000)
>> zsh: abort (core dumped)  ./tests/ahci-test
>
> Well, that's rather strange: I had to head out after your last
> follow-up, and then when picking this up again from home I ended up
> accidentally breaking my build directory and then did a fresh clean
> build. Now I can't reproduce the error. Running tests/ahci-test
> reports all OK.
>
> So I'm not quite sure what was wrong, but it looks like this is not a
> real issue -- sorry for the noise.
>

I'll take a swing:

You may have updated the ahci-test binary/source-code, but failed to 
rebuild the actual qemu binary which included the fixes that the newest 
test exercises.

I hope, anyway. (It would explain the problem on your little endian 
amd64 machine, at least.)

Thanks for the report and followup :)

--js

  reply	other threads:[~2015-04-01  0:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 16:56 [Qemu-devel] [PATCH 0/4] Ide patches for 2.3-rc1 John Snow
2015-03-23 16:56 ` [Qemu-devel] [PATCH 1/4] ide: fix cmd_write_pio when nsectors > 1 John Snow
2015-03-23 16:56 ` [Qemu-devel] [PATCH 2/4] ide: fix cmd_read_pio " John Snow
2015-03-23 16:56 ` [Qemu-devel] [PATCH 3/4] ahci: Fix sglist offset manipulation for BE machines John Snow
2015-03-23 16:56 ` [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns John Snow
2015-03-31 20:55   ` Ed Maste
2015-03-31 20:58     ` John Snow
2015-03-31 21:29       ` Ed Maste
2015-03-31 21:44         ` John Snow
2015-03-31 21:55           ` Ed Maste
2015-03-31 22:01             ` John Snow
2015-04-01  0:29             ` Ed Maste
2015-04-01  0:34               ` John Snow [this message]
2015-03-23 16:57 ` [Qemu-devel] [PATCH 0/4] Ide patches for 2.3-rc1 John Snow
2015-03-23 17:56 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551B3D0F.5030206@redhat.com \
    --to=jsnow@redhat.com \
    --cc=emaste@freebsd.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.