From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753430AbbDADBS (ORCPT ); Tue, 31 Mar 2015 23:01:18 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:36783 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbbDADBO (ORCPT ); Tue, 31 Mar 2015 23:01:14 -0400 Message-ID: <551B5F6E.3060904@gmail.com> Date: Wed, 01 Apr 2015 06:01:02 +0300 From: Yury User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrew Morton CC: linux@horizon.com, klimov.linux@gmail.com, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] lib: bitmap_[empty,full]: remove code duplication References: <1426528599-3735-1-git-send-email-yury.norov@gmail.com> <1427594635-11759-1-git-send-email-yury.norov@gmail.com> <20150331160638.8f622be3769fb1cc4418f582@linux-foundation.org> In-Reply-To: <20150331160638.8f622be3769fb1cc4418f582@linux-foundation.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.04.2015 02:06, Andrew Morton wrote: > On Sun, 29 Mar 2015 05:03:55 +0300 Yury Norov wrote: > >> Function 'bitmap_empty' has it's own implementation. >> But it's clearly as simple as: >> "find_first_bit(src, nbits) == nbits" >> The same is true for 'bitmap_full'. > Looks OK. > > Please send a Signed-off-by: for this patch. Hello Andrew, Is it enough? Signed-off-by: Yury Norov BR, Yury Norov