All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Joshua Kinard <kumba@gentoo.org>, Ralf Baechle <ralf@linux-mips.org>
Cc: Linux MIPS List <linux-mips@linux-mips.org>
Subject: Re: [PATCH]: MIPS: Select CONFIG_MIPS_O32_FP64_SUPPORT if 64bit kernel and o32
Date: Wed, 1 Apr 2015 09:01:49 +0100	[thread overview]
Message-ID: <551BA5ED.7060106@imgtec.com> (raw)
In-Reply-To: <551B9513.5020606@gentoo.org>

On 04/01/2015 07:49 AM, Joshua Kinard wrote:
> From: Joshua Kinard <kumba@gentoo.org>
> 
> Select CONFIG_MIPS_O32_FP64_SUPPORT by default if CONFIG_64BIT and
> CONFIG_MIPS32_O32 are selected.  This avoids breaking things when
> booting into an o32 userland under a 64bit kernel.  Symptoms of not
> selecting CONFIG_MIPS_O32_FP64_SUPPORT can include OpenSSH claiming that
> the "PRNG is not seeded" and Python programs to fail with either a
> SIGSEGV or errors regarding "float NaN".
> 
> Signed-off-by: Joshua Kinard <kumba@gentoo.org>
> ---
>  arch/mips/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> mips-fix-o32-fp64-on-mips64.patch
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 294f82e..1b826ed 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2736,6 +2736,7 @@ config MIPS32_O32
>  	select COMPAT
>  	select MIPS32_COMPAT
>  	select SYSVIPC_COMPAT if SYSVIPC
> +	select MIPS_O32_FP64_SUPPORT if 64BIT
>  	help
>  	  Select this option if you want to run o32 binaries.  These are pure
>  	  32-bit binaries as used by the 32-bit Linux/MIPS port.  Most of
> 
> 
Hi,

No this is not a good solution. This has already been fixed in
mips-for-linux-next and might make it to 4.0 in time

https://patchwork.linux-mips.org/patch/9344/

can you try that patch instead?

-- 
markos

  reply	other threads:[~2015-04-01  8:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01  6:49 [PATCH]: MIPS: Select CONFIG_MIPS_O32_FP64_SUPPORT if 64bit kernel and o32 Joshua Kinard
2015-04-01  8:01 ` Markos Chandras [this message]
2015-04-01 18:37   ` Joshua Kinard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551BA5ED.7060106@imgtec.com \
    --to=markos.chandras@imgtec.com \
    --cc=kumba@gentoo.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.