From: Marcel Apfelbaum <marcel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Tony Krowiak <akrowiak@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary
Date: Wed, 01 Apr 2015 11:06:17 +0300 [thread overview]
Message-ID: <551BA6F9.2070202@redhat.com> (raw)
In-Reply-To: <551BA5D1.8050002@redhat.com>
On 04/01/2015 11:01 AM, Paolo Bonzini wrote:
>
>
> On 01/04/2015 08:54, Marcel Apfelbaum wrote:
>> This is the first object for which QemuOps are defined per
>> sub-type and are not global (if you don't take "object" under
>> consideration).
>
> We can return the same QemuOpts that were included before.
> Per-machine-type options are new and need not be covered by
> query-command-line-options.
OK, we have them under hw/core/machine.c as "base" machine properties.
We still need a way to fill them back into QemuOpts right?
Maybe return them to the static global list? It seems like a step
back, but if there is no better way...
Thanks,
Marcel
>
> Paolo
>
>> I saw others as well, like netdev, but I am not sure what happens there.
>>
>> Once the QemuOpts are parsed, the only place we can find those options
>> is the machine object itself (as QOM properties).
>>
>> I see a few options here:
>> 1. Add a feature to QemuOpts: "Look for options in QOM properties of
>> this obj"
>> 2. Add a callback to QEMU opts that supplies the options (have machine
>> supply the callback)
>> 3. Have the machine object fill in the corresponding QemuOpts on init.
next prev parent reply other threads:[~2015-04-01 8:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 14:21 [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary Tony Krowiak
2015-04-01 6:54 ` Marcel Apfelbaum
2015-04-01 8:01 ` Paolo Bonzini
2015-04-01 8:06 ` Marcel Apfelbaum [this message]
2015-04-01 8:20 ` Paolo Bonzini
2015-04-01 8:42 ` Markus Armbruster
2015-04-01 9:07 ` Paolo Bonzini
2015-04-01 9:14 ` Marcel Apfelbaum
2015-04-01 9:23 ` Paolo Bonzini
2015-04-01 9:27 ` Marcel Apfelbaum
2015-04-01 8:28 ` Markus Armbruster
2015-04-01 14:51 ` Marcel Apfelbaum
2015-04-01 15:53 ` Markus Armbruster
2015-04-01 16:11 ` Marcel Apfelbaum
2015-04-01 16:20 ` Eric Blake
2015-04-01 16:31 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551BA6F9.2070202@redhat.com \
--to=marcel@redhat.com \
--cc=afaerber@suse.de \
--cc=akrowiak@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.