From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdFDG-0002OP-8l for qemu-devel@nongnu.org; Wed, 01 Apr 2015 05:45:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdFDD-0000kU-E1 for qemu-devel@nongnu.org; Wed, 01 Apr 2015 05:45:30 -0400 Received: from [59.151.112.132] (port=43997 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdFDD-0000eV-1X for qemu-devel@nongnu.org; Wed, 01 Apr 2015 05:45:27 -0400 Message-ID: <551BBDD1.7060207@cn.fujitsu.com> Date: Wed, 1 Apr 2015 17:43:45 +0800 From: Zhu Guihua MIME-Version: 1.0 References: <20150401104219.566d37c9@nial.brq.redhat.com> In-Reply-To: <20150401104219.566d37c9@nial.brq.redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/7] QEMU memory hot unplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: guz.fnst@cn.fujitsu.com, pbonzini@redhat.com, tangchen@cn.fujitsu.com, qemu-devel@nongnu.org, izumi.taku@jp.fujitsu.com On 04/01/2015 04:42 PM, Igor Mammedov wrote: > On Fri, 27 Mar 2015 17:20:33 +0800 > Zhu Guihua wrote: > >> Memory hot unplug are both asynchronous procedures. >> When the unplug operation happens, unplug request cb is called first. >> And when guest OS finished handling unplug, unplug cb will be called >> to do the real removal of device. > I think series is in good shape and ready for merging > after comments are fixed. I will fix all comments ASAP. Thanks for your hard work. Regards, Zhu > >> v5: >> -reorganize the patchset >> -add documentation to understand patch easily >> -add MEMORY_SLOT_EJECT for initiating device eject >> -add support to send qmp event to notify mgmt about memory unplug error >> >> v4: >> -reorganize the patchset >> -drop the new API acpi_send_gpe_event() >> -update ssdt-mem >> >> v3: >> -commit message changes >> -reorganize the patchset, squash and separate some patches >> -update specs about acpi_mem_hotplug >> -first cleanup external state, then un-map and un-register memory device >> >> v2: >> -do a generic for acpi to send gpe event >> -unparent object by PC_MACHINE >> -update description in acpi_mem_hotplug.txt >> -combine the last two patches in the last version >> -cleanup external state in acpi_memory_unplug_cb >> >> Tang Chen (3): >> acpi, mem-hotplug: add acpi_memory_slot_status() to get MemStatus >> acpi, mem-hotplug: add unplug request cb for memory device >> acpi, mem-hotplug: add unplug cb for memory device >> >> Zhu Guihua (4): >> docs: update documentation for memory hot unplug >> acpi: extend aml_field() to support UpdateRule >> acpi: add hardware implementation for memory hot unplug >> qmp-event: add event notification for memory hot unplug error >> >> docs/memory-hotplug.txt | 24 ++++++++-- >> docs/qmp/qmp-events.txt | 17 +++++++ >> docs/specs/acpi_mem_hotplug.txt | 32 ++++++++++++-- >> hw/acpi/aml-build.c | 4 +- >> hw/acpi/ich9.c | 19 ++++++-- >> hw/acpi/memory_hotplug.c | 93 ++++++++++++++++++++++++++++++++++++--- >> hw/acpi/piix4.c | 17 +++++-- >> hw/core/qdev.c | 2 +- >> hw/i386/acpi-build.c | 25 ++++++++--- >> hw/i386/acpi-dsdt-mem-hotplug.dsl | 13 +++++- >> hw/i386/pc.c | 62 ++++++++++++++++++++++++-- >> include/hw/acpi/aml-build.h | 10 ++++- >> include/hw/acpi/memory_hotplug.h | 12 +++++ >> include/hw/acpi/pc-hotplug.h | 3 ++ >> include/hw/qdev-core.h | 1 + >> monitor.c | 1 + >> qapi/event.json | 14 ++++++ >> trace-events | 2 + >> 18 files changed, 315 insertions(+), 36 deletions(-) >> > . >