From: Bob Liu <bob.liu@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org, jennifer.herbert@citrix.com,
LKML <linux-kernel@vger.kernel.org>,
boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()
Date: Wed, 01 Apr 2015 19:55:56 +0800 [thread overview]
Message-ID: <551BDCCC.20708@oracle.com> (raw)
In-Reply-To: <551BC5FF.2010107@citrix.com>
On 04/01/2015 06:18 PM, David Vrabel wrote:
> On 26/03/15 12:16, Bob Liu wrote:
>> There are several place using gnttab async unmap and wait for
>> completion, so move the common code to a function
>> gnttab_unmap_refs_async_wait_completion().
>>
> [...]
>> +
>> +int gnttab_unmap_refs_async_wait_completion(struct gntab_unmap_queue_data* item)
>
> This name is a bit wordy. Can you rename it to:
> gnttab_unmap_refs_sync() gnttab_unmap_refs_wait(), or
Sure, I think gnttab_unmap_refs_sync() is fine.
Will be updated.
> gnttab_unmap_refs_safe().
>
> (I can't decide which is the best name.).
>
> David
>
--
Regards,
-Bob
next prev parent reply other threads:[~2015-04-01 11:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 12:16 [PATCH RESEND 1/2] xen/blkback: safely unmap purge persistent grants Bob Liu
2015-03-26 12:16 ` [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion() Bob Liu
2015-03-26 15:32 ` Roger Pau Monné
2015-03-28 0:44 ` Konrad Rzeszutek Wilk
2015-03-30 0:03 ` Bob Liu
2015-03-30 0:03 ` Bob Liu
2015-04-01 10:05 ` David Vrabel
2015-04-01 10:05 ` [Xen-devel] " David Vrabel
2015-03-28 0:44 ` Konrad Rzeszutek Wilk
2015-03-26 15:32 ` Roger Pau Monné
2015-03-26 19:01 ` Konrad Rzeszutek Wilk
2015-03-26 19:01 ` Konrad Rzeszutek Wilk
2015-04-01 10:18 ` [Xen-devel] " David Vrabel
2015-04-01 11:55 ` Bob Liu
2015-04-01 11:55 ` Bob Liu [this message]
2015-04-01 10:18 ` David Vrabel
2015-03-26 12:16 ` Bob Liu
2015-03-26 15:23 ` [PATCH RESEND 1/2] xen/blkback: safely unmap purge persistent grants Roger Pau Monné
2015-03-26 19:01 ` Konrad Rzeszutek Wilk
2015-03-26 20:11 ` Jens Axboe
2015-03-26 20:11 ` Jens Axboe
2015-03-26 19:01 ` Konrad Rzeszutek Wilk
2015-03-26 15:23 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551BDCCC.20708@oracle.com \
--to=bob.liu@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jennifer.herbert@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.