From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753735AbbDAMFM (ORCPT ); Wed, 1 Apr 2015 08:05:12 -0400 Received: from mga01.intel.com ([192.55.52.88]:32648 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbbDAMFI (ORCPT ); Wed, 1 Apr 2015 08:05:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,503,1422950400"; d="scan'208";a="673734443" Message-ID: <551BDE5B.9050706@intel.com> Date: Wed, 01 Apr 2015 15:02:35 +0300 From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Jiri Olsa CC: Peter Zijlstra , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, David Ahern , Frederic Weisbecker , Namhyung Kim , Stephane Eranian Subject: Re: [PATCH V7 00/25] perf tools: Introduce an abstraction for AUX Area and Instruction Tracing References: <1427801934-25588-1-git-send-email-adrian.hunter@intel.com> <20150401115731.GH6992@krava.brq.redhat.com> In-Reply-To: <20150401115731.GH6992@krava.brq.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/15 14:57, Jiri Olsa wrote: > On Tue, Mar 31, 2015 at 02:38:29PM +0300, Adrian Hunter wrote: > > SNIP > >> >> Changes in V7: >> >> Changes requested by Jiri: >> >> perf evlist: Add initial support for mmapping an AUX area buffer >> WARN_ONCE if mm->base is not NULL when mmapping >> >> perf tools: Add support for AUX area recording >> Use perf_can_sample_identifier() consistently >> Drop unused function perf_event__synthesize_auxtrace() >> >> perf record: Add basic AUX area tracing support >> Check length before calling record__write a second time >> >> perf record: Extend -m option for AUX area tracing mmap pages >> Update change log with -m option change syntax > > I sent some acks, I'll continue the review the rest Thank you! :-)