All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Grandel <fgrandel@gmail.com>
To: BlueZ development <linux-bluetooth@vger.kernel.org>
Cc: Marcel Holtmann <marcel@holtmann.org>
Subject: Re: Multi-Advertising: implementation options, timing questions
Date: Wed, 01 Apr 2015 14:34:10 +0200	[thread overview]
Message-ID: <551BE5C2.3040101@gmail.com> (raw)
In-Reply-To: <2F40B83E-682C-47A4-A7A3-BF2CDE2DA4D5@holtmann.org>

Hi Marcel,

> See comment above, we can not really change legacy API.

Sure. I hoped that my proposal was just a change in implementation, not 
in behavior. But it doesn't seem to be an obvious improvement.

> It has to stay around for backwards compatibility. And that is why set advertising takes precedence over anything added by add advertising.

Yes, I understood that from the documentation of the mgmt api.

> What are you planning to verify here. The instance id is coming from userspace.

Oups. Seems so obvious but I overlooked it.

> Read up on what instance[0] actually does in a struct. We have used these constructs before. I am sensing that you misunderstood what this is for.

I think I understood what it does (struct hack?). I just didn't 
understand the intent of that field as it wasn't (yet) used anywhere in 
code. But I found it out in the meantime: You intend it to hold the 
currently occupied instance identifiers. I'll make sure it will be 
filled accordingly.

Thanks for your quick response!

Florian

  parent reply	other threads:[~2015-04-01 12:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 23:51 Nexus 4 in BLE peripheral role with bluez stack Florian Grandel
2015-03-28  0:01 ` Marcel Holtmann
2015-03-28  6:45   ` Multi-Advertising: implementation options, timing questions Florian Grandel
2015-03-28  6:57     ` Marcel Holtmann
2015-03-28 13:32       ` Florian Grandel
2015-03-28 20:18         ` Arman Uguray
2015-03-29 23:23           ` Florian Grandel
2015-03-30  0:48             ` Marcel Holtmann
2015-03-30 17:23               ` Jakub Pawlowski
2015-03-30 17:44                 ` Arman Uguray
2015-03-30 18:04                   ` Jakub Pawlowski
2015-03-30 21:57                 ` Marcel Holtmann
2015-03-30 22:26                   ` Jakub Pawlowski
2015-04-01 12:34               ` Florian Grandel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-03-30 22:37 Jakub Pawlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551BE5C2.3040101@gmail.com \
    --to=fgrandel@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.