All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	yunhong.jiang@intel.com
Cc: Ian Campbell <ian.campbell@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	xen-devel <xen-devel@lists.xen.org>
Subject: [Qemu-devel] Question about unbind MSI in xen_pt_msi.c
Date: Wed, 1 Apr 2015 13:51:28 +0100	[thread overview]
Message-ID: <551BE9D0.1090003@citrix.com> (raw)

Hi,

I'm looking to replace any call to xc_domain_bind_pt_irq and
xc_domain_unbind_pt_irq by specific IRQ type helpers.

I found one strange call which will always fail in xen_pt_msix_update_remap.
The function xc_domain_unbind_pt_irq is called with PT_IRQ_TYPE_MSI
which is not supported by the function.

I'm not familiar with x86 passthrough but this looks wrong to me. Am I
right? Shouldn't we replace this call by xc_domain_unbind_msi_irq?

Regards,

-- 
Julien Grall

             reply	other threads:[~2015-04-01 12:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 12:51 Julien Grall [this message]
2015-04-01 15:32 ` [Qemu-devel] Question about unbind MSI in xen_pt_msi.c Stefano Stabellini
2015-04-01 17:25   ` Julien Grall
2015-04-01 17:25   ` [Qemu-devel] " Julien Grall
2015-04-01 15:32 ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551BE9D0.1090003@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.