From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <551C030E.1090309@metafoo.de> Date: Wed, 01 Apr 2015 16:39:10 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Daniel Baluta , Kuppuswamy Sathyanarayanan CC: Jonathan Cameron , Peter Meerwald , "linux-iio@vger.kernel.org" , Srinivas Pandruvada Subject: Re: [PATCH v1 2/3] iio: ltr501: Add interrupt rate control support References: <212b45fac712e84a3cf0bc5955def7d1b683a6bd.1427856701.git.sathyanarayanan.kuppuswamy@linux.intel.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed List-ID: On 04/01/2015 04:04 PM, Daniel Baluta wrote: [...] > >> +static const struct iio_chan_spec_ext_info ltr501_ext_info[] = { >> + { >> + .name = "intr_persist", >> + .read = ltr501_read_intr_prst, >> + .write = ltr501_write_intr_prst, >> + .shared = IIO_SHARED_BY_TYPE, >> + }, >> + {}, >> +}; >> + > Would be nice to standardize persistence attribute (IIO_CHAN_INFO_PERSISTENCE). If I understand the behavior correctly it causes that the event needs to be triggered at least n times before the event is reported by the chip. In my opinion 'persistence' is not a good term for that. I'm not sure what a better term is but I think it should go more in the direction of ratelimit or something.