From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdLXg-0006Aj-LR for qemu-devel@nongnu.org; Wed, 01 Apr 2015 12:31:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdLXc-0005ht-EW for qemu-devel@nongnu.org; Wed, 01 Apr 2015 12:31:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdLXc-0005hQ-6Q for qemu-devel@nongnu.org; Wed, 01 Apr 2015 12:30:56 -0400 Message-ID: <551C1D3C.30908@redhat.com> Date: Wed, 01 Apr 2015 10:30:52 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427897284-31473-1-git-send-email-marcel@redhat.com> <551C0C02.3050003@redhat.com> In-Reply-To: <551C0C02.3050003@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8srbVgcuBGBg7sb8r5kC91vsmUu5xsrfi" Subject: Re: [Qemu-devel] [PATCH for-2.3] util/qemu-config" fix regression of qmp_query_command_line_options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, akrowiak@linux.vnet.ibm.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8srbVgcuBGBg7sb8r5kC91vsmUu5xsrfi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/01/2015 09:17 AM, Eric Blake wrote: > On 04/01/2015 08:08 AM, Marcel Apfelbaum wrote: >> Commit 49d2e64 (machine: remove qemu_machine_opts global list) made >> machine machine options specific to machine sub-type, leaving >=20 > At the risk of sounding like a machine: s/machine machine/machine/ >=20 >> the qemu_machine_opts desc array empty. Sadly this is the place >> qmp_query_command_line_options is looking for supported options. >> >> As a fix for for 2.3 the machine_qemu_opts are restored only >> for the scope of qemu-config, bringing together all machines >=20 > s/machines/machines'/ >=20 >> properties. We need to find a better fix for 2.4. As discussed on the other thread, we may want a v2: > I also tested that query-command-line-options on qemu.git + this patch > provided a superset of the options exposed by > 2:qemu-system-x86-2.1.3-3.fc21.x86_64 as installed on Fedora 21, while > without this patch it had no options. The problem is that the superset includes per-machine options, even for machines where they don't apply. I think it's better for 2.3 to be conservative (advertise no less than before, so we don't regress) than to lie (advertising something we don't support is risky). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8srbVgcuBGBg7sb8r5kC91vsmUu5xsrfi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVHB08AAoJEKeha0olJ0NqResH/Rk4cJkH20ZssqzQkSjZEeo3 o2aZql0Ty3rdVHm904RkAo8Vd4EmiNJVouO2S5i1ed+WlWNIH8psm1rSSaudd7c+ WRbquq9+cIoqTTILtq7Pdn7PNElqLjWegCSmIVg/BumwHNlzCA5fYIZeWbVnSz8L DNKFUYlmYWphnevrvLlxHK5D3+5eDHDLpUv2EcHT2C2+P/Hg6V8FiwoE2vDCm6an EYRU7HzA9OdjMRAOObn5jmPxg/OFQQ/gBLzkRAsFj9kJ2mrhLDAMvMbDVAf1/RGP WJ+yDQSJxR/g+BfywBmr7m+TbEmR1+3oy3afCDTT7Kj2S00HgRD8bMAdNZdP4q4= =8fXu -----END PGP SIGNATURE----- --8srbVgcuBGBg7sb8r5kC91vsmUu5xsrfi--