From: Guenter Roeck <linux@roeck-us.net>
To: James Hogan <james.hogan@imgtec.com>,
Andrew Bresticker <abrestic@chromium.org>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Ezequiel Garcia <ezequiel.garcia@imgtec.com>
Subject: Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree
Date: Wed, 01 Apr 2015 18:42:09 -0700 [thread overview]
Message-ID: <551C9E71.9010305@roeck-us.net> (raw)
In-Reply-To: <20150401222218.GB13077@jhogan-linux.le.imgtec.org>
On 04/01/2015 03:22 PM, James Hogan wrote:
> Hi Andrew,
>
> On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote:
>> Since the heartbeat is statically initialized to its default value,
>> watchdog_init_timeout() will never look in the device-tree for a
>> timeout-sec value. Instead of statically initializing heartbeat,
>> fall back to the default timeout value if watchdog_init_timeout()
>> fails.
>
> Whoops. Sorry about that. I wasn't aware that a timeout-sec value was
> expected. It isn't mentioned in the DT binding documentation for this
> device :-(.
>
Hi James,
This is a standard watchdog driver attribute. See
Documentation/watchdog/watchdog-kernel-api.txt.
[ Agreed, it would probably make sense to document that in the bindings. ]
Guenter
prev parent reply other threads:[~2015-04-02 1:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 17:43 [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree Andrew Bresticker
2015-04-01 17:43 ` [PATCH V2 2/3] watchdog: imgpdc: Set timeout before starting watchdog Andrew Bresticker
2015-04-01 17:43 ` [PATCH V2 3/3] watchdog: imgpdc: Add reboot support Andrew Bresticker
2015-04-01 22:22 ` [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree James Hogan
2015-04-01 22:42 ` Andrew Bresticker
2015-04-02 1:08 ` Guenter Roeck
2015-04-02 16:46 ` Andrew Bresticker
2015-04-03 1:52 ` Guenter Roeck
2015-04-03 2:16 ` Andrew Bresticker
2015-04-03 2:35 ` Guenter Roeck
2015-04-03 5:38 ` Guenter Roeck
2015-04-02 1:42 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551C9E71.9010305@roeck-us.net \
--to=linux@roeck-us.net \
--cc=abrestic@chromium.org \
--cc=ezequiel.garcia@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.