Re: [Outreachy kernel] [PATH v3] Staging: comedi: addi_apci_1564: Delete whitespace

[Charlie WONG Super <1213charlie@gmail.com>]

On 2015年04月01日 23:37, Greg KH wrote:
> On Tue, Mar 31, 2015 at 02:08:13PM +0800, Charlie Wong Super wrote:
>> Fix the checkpatch.pl WARNING: line over 80 characters
>>
>> Signed-off-by: Charlie Wong Super <1213charlie@gmail.com>
>> ---
>> Changes in v2:
>> 	edit the commit message, make it clear!
>> Changes in v3:
>> 	about the commit and patch style problem!
>> 	
>>   drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c b/drivers/staging/comedi/drivers/addi_apci_1564.c
>> index c481c48..dd335e8 100644
>> --- a/drivers/staging/comedi/drivers/addi_apci_1564.c
>> +++ b/drivers/staging/comedi/drivers/addi_apci_1564.c
>> @@ -106,12 +106,12 @@
>>   #define APCI1564_COUNTER(x)			((x) * 0x20)
>>   
>>   struct apci1564_private {
>> -	unsigned long eeprom;		/* base address of EEPROM register */
>> -	unsigned long timer;		/* base address of 12-bit timer */
>> -	unsigned long counters;		/* base address of 32-bit counters */
>> -	unsigned int mode1;		/* riding-edge/high level channels */
>> -	unsigned int mode2;		/* falling-edge/low level channels */
>> -	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */
>> +	unsigned long eeprom;		/*base address of EEPROM register*/
>> +	unsigned long timer;		/*base address of 12-bit timer*/
>> +	unsigned long counters;		/*base address of 32-bit counters*/
>> +	unsigned int mode1;		/*riding-edge/high level channels*/
>> +	unsigned int mode2;		/*falling-edge/low level channels*/
>> +	unsigned int ctrl;		/*interrupt mode OR (edge).AND(level)*/
> That makes the code look worse, sorry, we can't take this.  It's correct
> to have ' ' in comments after and before the '*' character.
>
> thanks,
>
> greg k-h
ok, got it, I will do much more work!
Thanks for your review!