Re: [PATCH 2/2] x86/efi: Fix memcmp check

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 02/04/15 09:24, Ross Lagerwall wrote:
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
>  xen/arch/x86/dmi_scan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/dmi_scan.c b/xen/arch/x86/dmi_scan.c
> index ec411e6..3749688 100644
> --- a/xen/arch/x86/dmi_scan.c
> +++ b/xen/arch/x86/dmi_scan.c
> @@ -203,7 +203,7 @@ void __init dmi_efi_get_table(const void *smbios, const void *smbios3)
>  	const struct smbios_eps *eps = smbios;
>  	const struct smbios3_eps *eps3 = smbios3;
>  
> -	if (eps3 && memcmp(eps3->anchor, "_SM3_", 5) &&
> +	if (eps3 && memcmp(eps3->anchor, "_SM3_", 5) == 0 &&
>  	    eps3->length >= sizeof(*eps3) &&
>  	    dmi_checksum(eps3, eps3->length)) {
>  		efi_smbios3_address = eps3->address;