From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ydi7k-0000uM-FX for qemu-devel@nongnu.org; Thu, 02 Apr 2015 12:37:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ydi7g-0003yI-Sh for qemu-devel@nongnu.org; Thu, 02 Apr 2015 12:37:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ydi7g-0003xk-Lv for qemu-devel@nongnu.org; Thu, 02 Apr 2015 12:37:40 -0400 Message-ID: <551D701F.6010409@redhat.com> Date: Thu, 02 Apr 2015 18:36:47 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1427981862-19783-1-git-send-email-pbonzini@redhat.com> <20150402143952.GJ15412@fam-t430.nay.redhat.com> <551D578B.5050102@redhat.com> <20150402151650.GK15412@fam-t430.nay.redhat.com> <551D5E61.7090305@redhat.com> <20150402162601.GL15412@fam-t430.nay.redhat.com> In-Reply-To: <20150402162601.GL15412@fam-t430.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] virtio-blk: correctly dirty guest memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, hangaohuai@huawei.com, zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, mst@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com, dgibson@redhat.com, peter.huangpeng@huawei.com On 02/04/2015 18:26, Fam Zheng wrote: > There is another problem with your patch - read_size is not initialized in > non-RW paths like scsi and flush. Right, but... > I think the optimization for write is a separate thing, though. Shouldn't below > patch already fix the migration issue? ... it also doesn't cover SCSI, does it? Paolo