From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH RFC v2 2/3] xen/shadow: fix shadow_track_dirty_vram to work on hvm guests Date: Thu, 2 Apr 2015 20:06:37 +0100 Message-ID: <551D933D.2030300@citrix.com> References: <1427970395-16203-1-git-send-email-roger.pau@citrix.com> <1427970395-16203-3-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YdkRu-00058v-Ox for xen-devel@lists.xenproject.org; Thu, 02 Apr 2015 19:06:42 +0000 In-Reply-To: <1427970395-16203-3-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Tim Deegan , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gMDIvMDQvMTUgMTE6MjYsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToKPiBNb2RpZnkgc2hhZG93 X3RyYWNrX2RpcnR5X3ZyYW0gdG8gdXNlIGEgbG9jYWwgYnVmZmVyIGFuZCB0aGVuIGZsdXNoIHRv IHRoZQo+IGd1ZXN0IHdpdGhvdXQgdGhlIHBhZ2luZ19sb2NrIGhlbGQuIFRoaXMgaXMgbW9kZWxl ZCBhZnRlcgo+IGhhcF90cmFja19kaXJ0eV92cmFtLgo+Cj4gU2lnbmVkLW9mZi1ieTogUm9nZXIg UGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+Cj4gQ2M6IFRpbSBEZWVnYW4gPHRpbUB4 ZW4ub3JnPgo+IENjOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+Cj4gQ2M6IEFuZHJl dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+CgpSZXZpZXdlZC1ieTogQW5kcmV3 IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4sIHN1YmplY3QgdG8gdHdvCmNvcnJl Y3Rpb25zIGFuZCBhIHN1Z2dlc3Rpb24uCgo+IC0tLQo+ICB4ZW4vYXJjaC94ODYvbW0vc2hhZG93 L2NvbW1vbi5jIHwgMTggKysrKysrKysrKysrKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4 Ni9tbS9zaGFkb3cvY29tbW9uLmMgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCj4g aW5kZXggMmU0M2Q2ZC4uOGZmZjQzYSAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC94ODYvbW0vc2hh ZG93L2NvbW1vbi5jCj4gKysrIGIveGVuL2FyY2gveDg2L21tL3NoYWRvdy9jb21tb24uYwo+IEBA IC0zNTE2LDcgKzM1MTYsNyBAQCBzdGF0aWMgdm9pZCBzaF9jbGVhbl9kaXJ0eV9iaXRtYXAoc3Ry dWN0IGRvbWFpbiAqZCkKPiAgaW50IHNoYWRvd190cmFja19kaXJ0eV92cmFtKHN0cnVjdCBkb21h aW4gKmQsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIGJlZ2lu X3BmbiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbnIsCj4g LSAgICAgICAgICAgICAgICAgICAgICAgICAgICBYRU5fR1VFU1RfSEFORExFXzY0KHVpbnQ4KSBk aXJ0eV9iaXRtYXApCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBYRU5fR1VFU1RfSEFO RExFXzY0KHVpbnQ4KSBndWVzdF9kaXJ0eV9iaXRtYXApCj4gIHsKPiAgICAgIGludCByYzsKPiAg ICAgIHVuc2lnbmVkIGxvbmcgZW5kX3BmbiA9IGJlZ2luX3BmbiArIG5yOwo+IEBAIC0zNTI2LDYg KzM1MjYsNyBAQCBpbnQgc2hhZG93X3RyYWNrX2RpcnR5X3ZyYW0oc3RydWN0IGRvbWFpbiAqZCwK PiAgICAgIHAybV90eXBlX3QgdDsKPiAgICAgIHN0cnVjdCBzaF9kaXJ0eV92cmFtICpkaXJ0eV92 cmFtOwo+ICAgICAgc3RydWN0IHAybV9kb21haW4gKnAybSA9IHAybV9nZXRfaG9zdHAybShkKTsK PiArICAgIHVpbnQ4X3QgKmRpcnR5X2JpdG1hcCA9IE5VTEw7Cj4gIAo+ICAgICAgaWYgKCBlbmRf cGZuIDwgYmVnaW5fcGZuIHx8IGVuZF9wZm4gPiBwMm0tPm1heF9tYXBwZWRfcGZuICsgMSApCj4g ICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gQEAgLTM1NTQsNiArMzU1NSwxMiBAQCBpbnQgc2hh ZG93X3RyYWNrX2RpcnR5X3ZyYW0oc3RydWN0IGRvbWFpbiAqZCwKPiAgICAgICAgICBnb3RvIG91 dDsKPiAgICAgIH0KPiAgCj4gKyAgICBkaXJ0eV9iaXRtYXAgPSB4emFsbG9jX2J5dGVzKGRpcnR5 X3NpemUpOwo+ICsgICAgaWYgKCBkaXJ0eV9iaXRtYXAgPT0gTlVMTCApCj4gKyAgICB7Cj4gKyAg ICAgICAgcmMgPSAtRU5PTUVNOwo+ICsgICAgICAgIGdvdG8gb3V0Owo+ICsgICAgfQo+ICAgICAg LyogVGhpcyBzaG91bGQgaGFwcGVuIHNlbGRvbWx5IChWaWRlbyBtb2RlIGNoYW5nZSksCj4gICAg ICAgKiBubyBuZWVkIHRvIGJlIGNhcmVmdWwuICovCj4gICAgICBpZiAoICFkaXJ0eV92cmFtICkK PiBAQCAtMzU4Nyw3ICszNTk0LDcgQEAgaW50IHNoYWRvd190cmFja19kaXJ0eV92cmFtKHN0cnVj dCBkb21haW4gKmQsCj4gICAgICB7Cj4gICAgICAgICAgLyogc3RpbGwgY29tcGxldGVseSBjbGVh biwganVzdCBjb3B5IG91ciBlbXB0eSBiaXRtYXAgKi8KPiAgICAgICAgICByYyA9IC1FRkFVTFQ7 Cj4gLSAgICAgICAgaWYgKCBjb3B5X3RvX2d1ZXN0KGRpcnR5X2JpdG1hcCwgZGlydHlfdnJhbS0+ ZGlydHlfYml0bWFwLCBkaXJ0eV9zaXplKSA9PSAwICkKPiArICAgICAgICBpZiAoIG1lbWNweShk aXJ0eV9iaXRtYXAsIGRpcnR5X3ZyYW0tPmRpcnR5X2JpdG1hcCwgZGlydHlfc2l6ZSkgIT0gTlVM TCApCgptZW1jcHkoKSByZXR1cm5zIGFuIGludCwgbm90IGEgcG9pbnRlci4gIFlvdSBzaG91bGQg dXNlICE9IDAKCj4gICAgICAgICAgICAgIHJjID0gMDsKPiAgICAgIH0KPiAgICAgIGVsc2UKPiBA QCAtMzY2OSw3ICszNjc2LDggQEAgaW50IHNoYWRvd190cmFja19kaXJ0eV92cmFtKHN0cnVjdCBk b21haW4gKmQsCj4gICAgICAgICAgICAgIHNoX3VubWFwX2RvbWFpbl9wYWdlKG1hcF9zbDFwKTsK PiAgCj4gICAgICAgICAgcmMgPSAtRUZBVUxUOwo+IC0gICAgICAgIGlmICggY29weV90b19ndWVz dChkaXJ0eV9iaXRtYXAsIGRpcnR5X3ZyYW0tPmRpcnR5X2JpdG1hcCwgZGlydHlfc2l6ZSkgPT0g MCApIHsKPiArICAgICAgICBpZiAoIG1lbWNweShkaXJ0eV9iaXRtYXAsIGRpcnR5X3ZyYW0tPmRp cnR5X2JpdG1hcCwgZGlydHlfc2l6ZSkgIT0gTlVMTCApCj4gKyAgICAgICAgewoKQW5kIGhlcmUu Cgo+ICAgICAgICAgICAgICBtZW1zZXQoZGlydHlfdnJhbS0+ZGlydHlfYml0bWFwLCAwLCBkaXJ0 eV9zaXplKTsKPiAgICAgICAgICAgICAgaWYgKGRpcnR5X3ZyYW0tPmxhc3RfZGlydHkgKyBTRUNP TkRTKDIpIDwgTk9XKCkpCj4gICAgICAgICAgICAgIHsKPiBAQCAtMzY5Nyw2ICszNzA1LDEwIEBA IG91dF9kaXJ0eV92cmFtOgo+ICAKPiAgb3V0Ogo+ICAgICAgcGFnaW5nX3VubG9jayhkKTsKPiAr ICAgIGlmICggcmMgPT0gMCAmJiBkaXJ0eV9iaXRtYXAgIT0gTlVMTCApCj4gKyAgICAgICAgaWYg KCBjb3B5X3RvX2d1ZXN0KGd1ZXN0X2RpcnR5X2JpdG1hcCwgZGlydHlfYml0bWFwLCBkaXJ0eV9z aXplKSAhPSAwICkKPiArICAgICAgICAgICAgcmMgPSAtRUZBVUxUOwoKVGhlc2UgdHdvIGlmKClz IGNhbiBiZSBqb2luZWQsIGFuZCBzaG9ydGVkIGZvciBicmV2aXR5LgoKaWYgKCAhcmMgJiYgZGly dHlfYml0bWFwICYmIGNvcHlfdG9fZ3Vlc3QoZ3Vlc3RfZGlydHlfYml0bWFwLApkaXJ0eV9iaXRt YXAsIGRpcnR5X3NpemUpICkKICAgIHJjID0gLUVGQVVMVDsKCn5BbmRyZXcKCj4gKyAgICB4ZnJl ZShkaXJ0eV9iaXRtYXApOwo+ICAgICAgcDJtX3VubG9jayhwMm1fZ2V0X2hvc3RwMm0oZCkpOwo+ ICAgICAgcmV0dXJuIHJjOwo+ICB9CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVu Lm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK