All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: Duncan <1i5t5.duncan@cox.net>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v3] btrfs-progs: Doc: Add warning and note on btrfs-convert.
Date: Fri, 3 Apr 2015 15:06:46 +0800	[thread overview]
Message-ID: <551E3C06.9040305@cn.fujitsu.com> (raw)
In-Reply-To: <pan$c078e$9a53acee$d6e24908$3d5c7666@cox.net>

> Qu Wenruo posted on Fri, 03 Apr 2015 09:21:15 +0800 as excerpted:
>
>> +WARNING: If one hopes to rollback to ext2/3/4, he or she should not execute
>> +*btrfs balance* command on converted btrfs.
>> +Since it will change the extent layout and make *btrfs-convert* unable to
>> +rollback.
>
> Because "since" is subordinating and the sentence doesn't contain what
> it is subordinated to as that's explained in the previous sentence,
> "Since it will..." introduces a sentence fragment.
Thanks.

It seems my English is really poor... :(
>
> Possible correction 1, combine the sentences:  Either simply eliminate
> the period following the previous sentence, or convert it to a comma,
> either way combining the sentences into one.
I'll take this one.

Thanks,
Qu
>
> Possible correction 2, eliminate the subordinator:  Eliminate "Since"
> and begin the second sentence with "A balance..." (replacing "it").
>
> Possible correction 3, reorder and edit, something like this:
>
> +WARNING: Do not execute a *btrfs balance" on a converted btrfs until you
> +are sure you will not rollback, as a balance changes the extent layout
> +and prevents btrfs-convert from successfully rolling back to ext2/3/4.
>

  reply	other threads:[~2015-04-03  7:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03  1:21 [PATCH v3] btrfs-progs: Doc: Add warning and note on btrfs-convert Qu Wenruo
2015-04-03  5:55 ` Duncan
2015-04-03  7:06   ` Qu Wenruo [this message]
2015-04-03  7:16     ` Roman Mamedov
2015-04-03  9:56       ` Duncan
2015-04-03  8:33     ` Duncan
2015-04-07 15:04     ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551E3C06.9040305@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=1i5t5.duncan@cox.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.