From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH v2] earlycon: 8250: Fix command line regression Date: Fri, 03 Apr 2015 22:29:00 -0400 Message-ID: <551F4C6C.6040108@hurleysoftware.com> References: <1428102229-26103-1-git-send-email-peter@hurleysoftware.com> <1428105875-4038-1-git-send-email-peter@hurleysoftware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Yinghai Lu Cc: Greg Kroah-Hartman , "linux-serial@vger.kernel.org" , Linux Kernel Mailing List , Jiri Slaby , Andrew Morton , Rob Herring List-Id: linux-serial@vger.kernel.org On 04/03/2015 10:19 PM, Yinghai Lu wrote: > On Fri, Apr 3, 2015 at 5:04 PM, Peter Hurley wrote: >> Restore undocumented behavior of kernel command line parameters of >> the forms: >> console=uart[8250],io|mmio|mmio32,[,options] >> console=uart[8250],[,options] >> where 'options' have not been specified; in this case, the hardware >> is assumed to be initialized. > > > Please separated bug fix and other documentation change to different patches. No. The documentation reflects exactly what the bug fix is for. > also fix the patch title to make it clear and you need to mention which commit > cause the regression. Please bisect and send bisect log so I know which commit broke your setup. > This patch fix regression for the hand over. Thanks. > > Another regression. > when user have > console=uart8250,io,0x3f8 console=uart8250,io,0x2f8 > > before your patchset: > port_0x3f8 is early console, and will be console later. > and port_0x2f8 is ignored, because only ONE early console is allowed. > and old console setup, only handle ttyS0. > > after your patchset: > port_0x3f8 is early console, and will be console later. > port_0x2f8 will become default console, as new console with match method > treat all uart8250 as ttyS0. > > Please fix that too. That's a new feature, not a regression.