From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu: revise retry init to fully cleanup driver
Date: Wed, 8 Nov 2017 10:42:54 +0100
Message-ID: <551ca484-9d4d-d0e3-cc70-e02e5405d690@gmail.com>
References: <1510111766-13170-1-git-send-email-Pixel.Ding@amd.com>
Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <1510111766-13170-1-git-send-email-Pixel.Ding-5C7GfCeVMHo@public.gmane.org>
Content-Language: en-US
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: Pixel Ding <Pixel.Ding-5C7GfCeVMHo@public.gmane.org>, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org

QW0gMDguMTEuMjAxNyB1bSAwNDoyOSBzY2hyaWViIFBpeGVsIERpbmc6Cj4gUmV0cnkgYXQgZHJt
X2Rldl9yZWdpc3RlciBpbnN0ZWFkIG9mIGFtZGdwdV9kZXZpY2VfaW5pdC4KPgo+IFNpZ25lZC1v
ZmYtYnk6IFBpeGVsIERpbmcgPFBpeGVsLkRpbmdAYW1kLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMv
Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyB8ICAyICsrCj4gICBkcml2ZXJzL2dw
dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZHJ2LmMgICAgfCAxMSArKysrKysrKystLQo+ICAgZHJp
dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5jICAgIHwgMTUgKystLS0tLS0tLS0t
LS0tCj4gICAzIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygt
KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZp
Y2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+IGluZGV4
IGJmMmIwMDguLjRlZjJiMWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn
cHUvYW1kZ3B1X2RldmljZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k
Z3B1X2RldmljZS5jCj4gQEAgLTIzOTAsNiArMjM5MCw4IEBAIGludCBhbWRncHVfZGV2aWNlX2lu
aXQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gICAJCSAgICBhbWRncHVfdmlydF9tbWlv
X2Jsb2NrZWQoYWRldikgJiYKPiAgIAkJICAgICFhbWRncHVfdmlydF93YWl0X3Jlc2V0KGFkZXYp
KSB7Cj4gICAJCQlkZXZfZXJyKGFkZXYtPmRldiwgIlZGIGV4Y2x1c2l2ZSBtb2RlIHRpbWVvdXRc
biIpOwo+ICsJCQlhZGV2LT52aXJ0LmNhcHMgJj0gfkFNREdQVV9TUklPVl9DQVBTX1JVTlRJTUU7
Cj4gKwkJCWFkZXYtPnZpcnQub3BzID0gTlVMTDsKCldoeSBpcyB0aGF0IG5lY2Vzc2FyeT8gTWF5
YmUgcHV0IHRoaXMgaW50byBzb21lIFNSSU9WIHNwZWNpZmljIGZpbmkgCmZ1bmN0aW9uPwoKQXBh
cnQgZnJvbSB0aGF0IHBhdGNoIGxvb2tzIGdvb2QgdG8gbWUgYW5kIGlzIEFja2VkLWJ5OiBDaHJp
c3RpYW4gS8O2bmlnIAo8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPi4KClJlZ2FyZHMsCkNocmlz
dGlhbi4KCj4gICAJCQlyID0gLUVBR0FJTjsKPiAgIAkJCWdvdG8gZmFpbGVkOwo+ICAgCQl9Cj4g
ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kcnYuYyBiL2Ry
aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kcnYuYwo+IGluZGV4IDZiMTFhNzUuLmVh
Y2NkNGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Ry
di5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rydi5jCj4gQEAg
LTU2NSwxMiArNTY1LDEzIEBAIHN0YXRpYyBpbnQgYW1kZ3B1X2tpY2tfb3V0X2Zpcm13YXJlX2Zi
KHN0cnVjdCBwY2lfZGV2ICpwZGV2KQo+ICAgCXJldHVybiAwOwo+ICAgfQo+ICAgCj4gKwo+ICAg
c3RhdGljIGludCBhbWRncHVfcGNpX3Byb2JlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LAo+ICAgCQkJ
ICAgIGNvbnN0IHN0cnVjdCBwY2lfZGV2aWNlX2lkICplbnQpCj4gICB7Cj4gICAJc3RydWN0IGRy
bV9kZXZpY2UgKmRldjsKPiAgIAl1bnNpZ25lZCBsb25nIGZsYWdzID0gZW50LT5kcml2ZXJfZGF0
YTsKPiAtCWludCByZXQ7Cj4gKwlpbnQgcmV0LCByZXRyeSA9IDA7Cj4gICAKPiAgIAlpZiAoKGZs
YWdzICYgQU1EX0VYUF9IV19TVVBQT1JUKSAmJiAhYW1kZ3B1X2V4cF9od19zdXBwb3J0KSB7Cj4g
ICAJCURSTV9JTkZPKCJUaGlzIGhhcmR3YXJlIHJlcXVpcmVzIGV4cGVyaW1lbnRhbCBoYXJkd2Fy
ZSBzdXBwb3J0LlxuIgo+IEBAIC02MDMsOCArNjA0LDE0IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3Bj
aV9wcm9iZShzdHJ1Y3QgcGNpX2RldiAqcGRldiwKPiAgIAo+ICAgCXBjaV9zZXRfZHJ2ZGF0YShw
ZGV2LCBkZXYpOwo+ICAgCj4gK3JldHJ5X2luaXQ6Cj4gICAJcmV0ID0gZHJtX2Rldl9yZWdpc3Rl
cihkZXYsIGVudC0+ZHJpdmVyX2RhdGEpOwo+IC0JaWYgKHJldCkKPiArCWlmIChyZXQgPT0gLUVB
R0FJTiAmJiArK3JldHJ5IDw9IDMpIHsKPiArCQlEUk1fSU5GTygicmV0cnkgaW5pdCAlZFxuIiwg
cmV0cnkpOwo+ICsJCS8qIERvbid0IHJlcXVlc3QgRVggbW9kZSB0b28gZnJlcXVlbnRseSB3aGlj
aCBpcyBhdHRhY2tpbmcgKi8KPiArCQltc2xlZXAoNTAwMCk7Cj4gKwkJZ290byByZXRyeV9pbml0
Owo+ICsJfSBlbHNlIGlmIChyZXQpCj4gICAJCWdvdG8gZXJyX3BjaTsKPiAgIAo+ICAgCXJldHVy
biAwOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21z
LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLmMKPiBpbmRleCAxZDU2
YjViLi42NTM2MGNkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft
ZGdwdV9rbXMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9rbXMu
Ywo+IEBAIC04NCw3ICs4NCw3IEBAIHZvaWQgYW1kZ3B1X2RyaXZlcl91bmxvYWRfa21zKHN0cnVj
dCBkcm1fZGV2aWNlICpkZXYpCj4gICBpbnQgYW1kZ3B1X2RyaXZlcl9sb2FkX2ttcyhzdHJ1Y3Qg
ZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBsb25nIGZsYWdzKQo+ICAgewo+ICAgCXN0cnVjdCBh
bWRncHVfZGV2aWNlICphZGV2Owo+IC0JaW50IHIsIGFjcGlfc3RhdHVzLCByZXRyeSA9IDA7Cj4g
KwlpbnQgciwgYWNwaV9zdGF0dXM7Cj4gICAKPiAgICNpZmRlZiBDT05GSUdfRFJNX0FNREdQVV9T
SQo+ICAgCWlmICghYW1kZ3B1X3NpX3N1cHBvcnQpIHsKPiBAQCAtMTIwLDcgKzEyMCw2IEBAIGlu
dCBhbWRncHVfZHJpdmVyX2xvYWRfa21zKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVk
IGxvbmcgZmxhZ3MpCj4gICAJCX0KPiAgIAl9Cj4gICAjZW5kaWYKPiAtcmV0cnlfaW5pdDoKPiAg
IAo+ICAgCWFkZXYgPSBremFsbG9jKHNpemVvZihzdHJ1Y3QgYW1kZ3B1X2RldmljZSksIEdGUF9L
RVJORUwpOwo+ICAgCWlmIChhZGV2ID09IE5VTEwpIHsKPiBAQCAtMTQzLDE3ICsxNDIsNyBAQCBp
bnQgYW1kZ3B1X2RyaXZlcl9sb2FkX2ttcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25l
ZCBsb25nIGZsYWdzKQo+ICAgCSAqIFZSQU0gYWxsb2NhdGlvbgo+ICAgCSAqLwo+ICAgCXIgPSBh
bWRncHVfZGV2aWNlX2luaXQoYWRldiwgZGV2LCBkZXYtPnBkZXYsIGZsYWdzKTsKPiAtCWlmIChy
ID09IC1FQUdBSU4gJiYgKytyZXRyeSA8PSAzKSB7Cj4gLQkJYWRldi0+dmlydC5jYXBzICY9IH5B
TURHUFVfU1JJT1ZfQ0FQU19SVU5USU1FOwo+IC0JCWFkZXYtPnZpcnQub3BzID0gTlVMTDsKPiAt
CQlhbWRncHVfZGV2aWNlX2ZpbmkoYWRldik7Cj4gLQkJa2ZyZWUoYWRldik7Cj4gLQkJZGV2LT5k
ZXZfcHJpdmF0ZSA9IE5VTEw7Cj4gLQkJLyogRG9uJ3QgcmVxdWVzdCBFWCBtb2RlIHRvbyBmcmVx
dWVudGx5IHdoaWNoIGlzIGF0dGFja2luZyAqLwo+IC0JCW1zbGVlcCg1MDAwKTsKPiAtCQlkZXZf
ZXJyKCZkZXYtPnBkZXYtPmRldiwgInJldHJ5IGluaXQgJWRcbiIsIHJldHJ5KTsKPiAtCQlnb3Rv
IHJldHJ5X2luaXQ7Cj4gLQl9IGVsc2UgaWYgKHIpIHsKPiArCWlmIChyKSB7Cj4gICAJCWRldl9l
cnIoJmRldi0+cGRldi0+ZGV2LCAiRmF0YWwgZXJyb3IgZHVyaW5nIEdQVSBpbml0XG4iKTsKPiAg
IAkJZ290byBvdXQ7Cj4gICAJfQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0
b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1k
LWdmeAo=