From: Alexey Khoroshilov <khoroshilov@ispras.ru>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
ldv-project@linuxtesting.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] marvell-ccic: fix memory leak on failure path in cafe_smbus_setup()
Date: Sat, 04 Apr 2015 19:59:19 +0300 [thread overview]
Message-ID: <55201867.1070602@ispras.ru> (raw)
In-Reply-To: <20150404153647.01d475a5@lwn.net>
On 04.04.2015 16:36, Jonathan Corbet wrote:
> On Sat, 4 Apr 2015 03:16:01 +0300
> Alexey Khoroshilov <khoroshilov@ispras.ru> wrote:
>
>> If i2c_add_adapter() fails, adap is not deallocated.
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
>
> Actually, the worse thing is that it leaves the IRQ enabled...it's good
> you moved that lines down. Even better, of course, that the failure path
> has probably never been run during the life of this driver...:)
And hopefully it will not, but we will be ready:)
>
> Should there be some sort of proper reported-by line for the driver
> verification project?
Till now, we used "Found by" line, but we are open to any better way.
>
> Acked-by: Jonathan Corbet <corbet@lwn.net>
--
Alexey
prev parent reply other threads:[~2015-04-04 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-04 0:16 [PATCH] [media] marvell-ccic: fix memory leak on failure path in cafe_smbus_setup() Alexey Khoroshilov
2015-04-04 13:36 ` Jonathan Corbet
2015-04-04 16:59 ` Alexey Khoroshilov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55201867.1070602@ispras.ru \
--to=khoroshilov@ispras.ru \
--cc=corbet@lwn.net \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.