From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752777AbbDDWEf (ORCPT ); Sat, 4 Apr 2015 18:04:35 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752483AbbDDWEe (ORCPT ); Sat, 4 Apr 2015 18:04:34 -0400 Message-ID: <55205FEE.6020408@nod.at> Date: Sun, 05 Apr 2015 00:04:30 +0200 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Chen Gang CC: realmz6@gmail.com, "Kirill A. Shutemov" , Andrew Morton , "adi-buildroot-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Geert Uytterhoeven Subject: Re: [PATCH] blackfin: include: asm: pgtable: Define dummy pgprot_writecombine References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 05.04.2015 um 00:02 schrieb Chen Gang: > On 4/4/15 06:50, Richard Weinberger wrote: >> On Fri, Apr 3, 2015 at 10:36 PM, Chen Gang wrote: >>> It is copied from asm-generic, the related error with allmodconfig: >>> >>> CC [M] sound/core/pcm_native.o >>> sound/core/pcm_native.c: In function 'snd_pcm_lib_default_mmap': >>> sound/core/pcm_native.c:3387:24: error: implicit declaration of function 'pgprot_writecombine' [-Werror=implicit-function-declaration] >>> area->vm_page_prot = pgprot_writecombine(area->vm_page_prot); >>> ^ >>> sound/core/pcm_native.c:3387:22: error: incompatible types when assigning to type 'pgprot_t {aka struct }' from type 'int' >>> area->vm_page_prot = pgprot_writecombine(area->vm_page_prot); >>> ^ >>> >>> Signed-off-by: Chen Gang >>> --- >>> arch/blackfin/include/asm/pgtable.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/blackfin/include/asm/pgtable.h b/arch/blackfin/include/asm/pgtable.h >>> index b88a155..3e730d9 100644 >>> --- a/arch/blackfin/include/asm/pgtable.h >>> +++ b/arch/blackfin/include/asm/pgtable.h >>> @@ -36,6 +36,7 @@ typedef pte_t *pte_addr_t; >>> #define PAGE_READONLY __pgprot(0) /* these mean nothing to NO_MM */ >>> #define PAGE_KERNEL __pgprot(0) /* these mean nothing to NO_MM */ >>> #define pgprot_noncached(prot) (prot) >>> +#define pgprot_writecombine pgprot_noncached >> >> This looks fishy as blackfin's pgtable.h already includes asm-generic/pgtable.h. >> So, copy&pasting pgprot_writecombine shouldn't be needed. >> > > pgprot_writecombine in asm-generic/pgtable.h needs MMU, but allmodconfig > for blackfin is NOMMU. > > So, I still suggest to add dummy one in blackfin (although for me, asm- > generic/pgtable.h may need improvement -- welcome other members for it). Sounds still fishy as you "introduced" allmodconfig... Thanks, //richard