All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beomho Seo <beomho.seo@samsung.com>
To: sre@kernel.org
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	cw00.choi@samsung.com, inki.dae@samsung.com,
	sangbae90.lee@samsung.com
Subject: Re: [PATCH v2 1/2] power: max17042_battery: Use reg type instead of chip type
Date: Mon, 06 Apr 2015 22:34:15 +0900	[thread overview]
Message-ID: <55228B57.7@samsung.com> (raw)
In-Reply-To: <CAJKOXPe9wRK-TYXkMbN0h6B6zWSTYJRvLy8Ji6vWLULxaRbreQ@mail.gmail.com>

On 04/03/2015 06:01 PM, Krzysztof Kozlowski wrote:
> 2015-04-03 10:26 GMT+02:00 Beomho Seo <beomho.seo@samsung.com>:
>> Currently, max17042 battery driver choose register map by MAX17042_DevName
>> register. But it is return IC specific firmware version. So other maxim chip
>> hard to use this drvier. This patch choose chip type from driver_data.
>>
>> Cc: Sebastian Reichel <sre@kernel.org>
>> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
>> ---
>>  drivers/power/max17042_battery.c       |   33 ++++++++++----------------------
>>  include/linux/power/max17042_battery.h |    9 ++++++++-
>>  2 files changed, 18 insertions(+), 24 deletions(-)
> 
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> Best regards,
> Krzysztof
> 

Thanks Krzysztof for your reviews.

Sebastian, Could you please merge that your git tree?

Best regards
Beomho



  reply	other threads:[~2015-04-06 13:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03  8:26 [PATCH v2 0/2] power: max17042-battery: Modify max17042 battery driver Beomho Seo
2015-04-03  8:26 ` [PATCH v2 1/2] power: max17042_battery: Use reg type instead of chip type Beomho Seo
2015-04-03  9:01   ` Krzysztof Kozlowski
2015-04-06 13:34     ` Beomho Seo [this message]
2015-04-03  8:26 ` [PATCH v2 2/2] power: max17042_battery: add missed blank Beomho Seo
2015-04-06 15:54 ` [PATCH v2 0/2] power: max17042-battery: Modify max17042 battery driver Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55228B57.7@samsung.com \
    --to=beomho.seo@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=inki.dae@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sangbae90.lee@samsung.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.