From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain Date: Mon, 6 Apr 2015 16:15:52 +0200 Message-ID: <55229518.4010306@citrix.com> References: <551505B3.9020505@caviumnetworks.com> , <55155557.7020103@linaro.org> <1427462781997.9237@caviumnetworks.com> <1427877031.2115.212.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1427877031.2115.212.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Stefano Stabellini Cc: "Prasun.kapoor@cavium.com" , "Jaggi, Manish" , Julien Grall , "Kumar, Vijaya" , Xen Devel List-Id: xen-devel@lists.xenproject.org Hi Ian, On 01/04/2015 10:30, Ian Campbell wrote: > On Tue, 2015-03-31 at 17:48 +0100, Stefano Stabellini wrote: >> If it helps we could add a couple of comments on top of the structs in >> smmu.c to explain the meaning of the fields, like: >> >> >> /* iommu_domain, not to be confused with a Xen domain */ > > I was going to suggest something similar but more expansive, i.e. a > table of them all in one place (i.e. at the top of the file) for ease of > referencing: > > Struct Name What Wherefrom Normally found in > --------------------------------------------------------------------- > iommu_domain IOMMU Context Linux d->arch.blah > arch_smmu_xen_device Device specific Xen device->arch.blurg The actual name of the structure is arm_smmu_xen_device not arch_smmu_xen_device. Did you suggest to rename the name? Regards, -- Julien Grall