From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YfB6Z-0002mz-BD for mharc-qemu-trivial@gnu.org; Mon, 06 Apr 2015 13:46:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfB6X-0002l0-2S for qemu-trivial@nongnu.org; Mon, 06 Apr 2015 13:46:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfB6R-00073d-TK for qemu-trivial@nongnu.org; Mon, 06 Apr 2015 13:46:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfB6R-00072g-M7; Mon, 06 Apr 2015 13:46:27 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t36HkGro009842 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 6 Apr 2015 13:46:16 -0400 Received: from scv.usersys.redhat.com (dhcp-17-29.bos.redhat.com [10.18.17.29]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t36HkFaU020540; Mon, 6 Apr 2015 13:46:15 -0400 Message-ID: <5522C667.80200@redhat.com> Date: Mon, 06 Apr 2015 13:46:15 -0400 From: John Snow User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Peter Maydell , Ed Maste References: <1427911244-22565-1-git-send-email-emaste@freebsd.org> <551C5DE7.70904@redhat.com> <551C5FAF.7010303@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: QEMU Trivial , Paolo Bonzini , QEMU Developers Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2015 17:46:34 -0000 On 04/03/2015 07:18 AM, Peter Maydell wrote: > On 2 April 2015 at 20:31, Ed Maste wrote: >> On 1 April 2015 at 18:45, Peter Maydell wrote: >>> Also irritating is the way it silently requires >>> the binary to have a name in the shape it was >>> expecting, which can catch you out if you were >>> trying to set it to a wrapper shell script that >>> invokes valgrind or something... >> >> I don't really have enough context to propose a good user-facing >> message with a tip for manually executing this, so hopefully someone >> else can provide one. I just noticed one other instance that already >> had an assertion on getenv("QTEST_QEMU_BINARY") being non-null. > > Yes, that was just me venting about something that caught me > out in the past rather than review comment on this patch :-) > Sorry for any confusion. > > -- PMM > I'll pull this into ide-next for 2.4 -- I have some ahci-test things to submit anyway. I'll touch up the user facing error messages in a later patch and hit a few of the startup assertions all at once. Thanks. --js From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfB6Y-0002mp-UE for qemu-devel@nongnu.org; Mon, 06 Apr 2015 13:46:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfB6X-00076a-UC for qemu-devel@nongnu.org; Mon, 06 Apr 2015 13:46:34 -0400 Message-ID: <5522C667.80200@redhat.com> Date: Mon, 06 Apr 2015 13:46:15 -0400 From: John Snow MIME-Version: 1.0 References: <1427911244-22565-1-git-send-email-emaste@freebsd.org> <551C5DE7.70904@redhat.com> <551C5FAF.7010303@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Ed Maste Cc: QEMU Trivial , Paolo Bonzini , QEMU Developers On 04/03/2015 07:18 AM, Peter Maydell wrote: > On 2 April 2015 at 20:31, Ed Maste wrote: >> On 1 April 2015 at 18:45, Peter Maydell wrote: >>> Also irritating is the way it silently requires >>> the binary to have a name in the shape it was >>> expecting, which can catch you out if you were >>> trying to set it to a wrapper shell script that >>> invokes valgrind or something... >> >> I don't really have enough context to propose a good user-facing >> message with a tip for manually executing this, so hopefully someone >> else can provide one. I just noticed one other instance that already >> had an assertion on getenv("QTEST_QEMU_BINARY") being non-null. > > Yes, that was just me venting about something that caught me > out in the past rather than review comment on this patch :-) > Sorry for any confusion. > > -- PMM > I'll pull this into ide-next for 2.4 -- I have some ahci-test things to submit anyway. I'll touch up the user facing error messages in a later patch and hit a few of the startup assertions all at once. Thanks. --js