From: Rik van Riel <riel@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Kelley Nielsen <kelleynnn@gmail.com>
Cc: linux-mm@kvack.org, riel@surriel.com,
opw-kernel@googlegroups.com, hughd@google.com,
jamieliu@google.com, sjenning@linux.vnet.ibm.com,
sarah.a.sharp@intel.com
Subject: Re: [RFC v7 2/2] mm: swapoff prototype: frontswap handling added
Date: Mon, 06 Apr 2015 14:57:22 -0400 [thread overview]
Message-ID: <5522D712.3090202@redhat.com> (raw)
In-Reply-To: <20150324151034.ade239edc6386c206a311d82@linux-foundation.org>
On 03/24/2015 06:10 PM, Andrew Morton wrote:
> On Thu, 19 Mar 2015 03:55:45 -0700 Kelley Nielsen <kelleynnn@gmail.com> wrote:
>
>> The prototype of the new swapoff (without the quadratic complexity)
>> presently ignores the frontswap case. Pass the count of
>> pages_to_unuse down the page table walks in try_to_unuse(),
>> and return from the walk when the desired number of pages
>> has been swapped back in.
>
> Does this fix the "TODO" in [1/2]?
>
> Do you think this patchset is ready for testing (while Hugh reviews it
> :)), or is there some deeper reason behind the "RFC"?
The patches look good to me, and this seems to
address the TODO from patch 1/2.
Acked-by: Rik van Riel <riel@redhat.com>
Kelley put in a heroic amount of effort tracking down
and fixing the corner cases I failed to anticipate
before putting this up as an OPW internship project.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-04-06 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 10:55 [RFC v7 2/2] mm: swapoff prototype: frontswap handling added Kelley Nielsen
2015-03-24 22:10 ` Andrew Morton
2015-04-06 18:57 ` Rik van Riel [this message]
2015-04-22 19:01 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5522D712.3090202@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jamieliu@google.com \
--cc=kelleynnn@gmail.com \
--cc=linux-mm@kvack.org \
--cc=opw-kernel@googlegroups.com \
--cc=riel@surriel.com \
--cc=sarah.a.sharp@intel.com \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.