All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/8] sandbox: Add support for bootz
Date: Mon, 06 Apr 2015 15:40:25 -0600	[thread overview]
Message-ID: <5522FD49.1070705@wwwdotorg.org> (raw)
In-Reply-To: <1428354148-1511-4-git-send-email-sjoerd.simons@collabora.co.uk>

On 04/06/2015 03:02 PM, Sjoerd Simons wrote:
> Add dummy bootz_setup implementation allowing the u-boot sandbox to
> run bootz. This recognizes both ARM and x86 zImages to validate a
> valid zImage was loaded.

> diff --git a/arch/sandbox/lib/bootm.c b/arch/sandbox/lib/bootm.c

> +int bootz_setup(ulong image, ulong *start, ulong *end)

> +	*start = 0xdead;
> +	*end = 0xbeef;
> +	return 0;

Isn't that going to cause the rest of bootz to access or jump to some 
bogus address and crash?

Aside from that, this series looks plausible, so,
Acked-by: Stephen Warren <swarren@nvidia.com>

(I read through patch 6 most thoroughly, briefly skimmed patch 7, and 
read the others fairly quickly, so take that as an ack primarily on 
patch 6 although I didn't see anything obviously wrong elsewhere).

  reply	other threads:[~2015-04-06 21:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-06 21:02 [U-Boot] [PATCH v2 0/8] Allow sandbox to use config_distro_bootcmd Sjoerd Simons
2015-04-06 21:02 ` [U-Boot] [PATCH v2 1/8] sandbox: only do sandboxfs for hostfs interface Sjoerd Simons
2015-04-07 20:40   ` Simon Glass
2015-04-06 21:02 ` [U-Boot] [PATCH v2 2/8] sandbox: Split bootm code out into lib/bootm Sjoerd Simons
2015-04-07 20:40   ` Simon Glass
2015-04-06 21:02 ` [U-Boot] [PATCH v2 3/8] sandbox: Add support for bootz Sjoerd Simons
2015-04-06 21:40   ` Stephen Warren [this message]
2015-04-07  7:56     ` Sjoerd Simons
2015-04-07 20:40       ` Simon Glass
2015-04-07 21:00         ` Stephen Warren
2015-04-07 22:31           ` Simon Glass
2015-04-06 21:02 ` [U-Boot] [PATCH v2 4/8] sandbox: Renamed sb command to host Sjoerd Simons
2015-04-07 20:40   ` Simon Glass
2015-04-06 21:02 ` [U-Boot] [PATCH v2 5/8] sandbox: Implement host dev [device] Sjoerd Simons
2015-04-07 20:40   ` Simon Glass
2015-04-06 21:02 ` [U-Boot] [PATCH v2 6/8] config_distro_bootcmd.h: Add shared block definition for the host interface Sjoerd Simons
2015-04-07 20:40   ` Simon Glass
2015-04-06 21:02 ` [U-Boot] [PATCH v2 7/8] pxe: Ensure all memory access is to mapped memory Sjoerd Simons
2015-04-07 20:41   ` Simon Glass
2015-04-06 21:02 ` [U-Boot] [PATCH v2 8/8] sandbox: add config_distro_defaults and config_distro_bootcmd Sjoerd Simons
2015-04-07 20:41   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5522FD49.1070705@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.