From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andy Lutomirski" <luto@kernel.org>, "Radim Krčmář" <rkrcmar@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kvm list <kvm@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] x86: vdso: fix pvclock races with task migration
Date: Tue, 07 Apr 2015 00:04:42 +0200 [thread overview]
Message-ID: <552302FA.3090804@redhat.com> (raw)
In-Reply-To: <5522E789.6070804@kernel.org>
On 06/04/2015 22:07, Andy Lutomirski wrote:
> On 04/02/2015 11:59 AM, Andy Lutomirski wrote:
>> On Thu, Apr 2, 2015 at 11:44 AM, Radim Krčmář <rkrcmar@redhat.com> wrote:
>>> If we were migrated right after __getcpu, but before reading the
>>> migration_count, we wouldn't notice that we read TSC of a different
>>> VCPU, nor that KVM's bug made pvti invalid, as only migration_count
>>> on source VCPU is increased.
>>>
>>> Change vdso instead of updating migration_count on destination.
>>
>> Looks good to me.
>
> Just to check: what tree is this intended to go through? I can take it,
> but not until the previous patch makes it into Linus' tree or -tip. Or
> I can take both patches.
I'll take it for 4.1.
Paolo
next prev parent reply other threads:[~2015-04-06 22:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 18:44 [PATCH] x86: vdso: fix pvclock races with task migration Radim Krčmář
2015-04-02 18:59 ` Andy Lutomirski
2015-04-06 20:07 ` Andy Lutomirski
2015-04-06 22:04 ` Paolo Bonzini [this message]
2015-04-06 20:57 ` Marcelo Tosatti
2015-04-07 11:11 ` Paolo Bonzini
2015-04-07 12:47 ` Radim Krčmář
2015-04-07 13:57 ` Paolo Bonzini
2015-04-29 12:07 ` Patch "x86: vdso: fix pvclock races with task migration" has been added to the 4.0-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552302FA.3090804@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mtosatti@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.