All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>
Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com,
	George.Dunlap@eu.citrix.com, Dongxiao Xu <dongxiao.xu@intel.com>,
	JBeulich@suse.com, Chao Peng <chao.p.peng@linux.intel.com>
Subject: Re: [RFC PATCH 0/7] Intel Cache Monitoring: Current Status and Future Opportunities
Date: Tue, 7 Apr 2015 11:27:07 +0100	[thread overview]
Message-ID: <5523B0FB.8020509@citrix.com> (raw)
In-Reply-To: <20150404020423.22875.23590.stgit@Solace.station>

On 04/04/2015 03:14, Dario Faggioli wrote:
> Hi Everyone,
>
> This RFC series is the outcome of an investigation I've been doing about
> whether we can take better advantage of features like Intel CMT (and of PSR
> features in general). By "take better advantage of" them I mean, for example,
> use the data obtained from monitoring within the scheduler and/or within
> libxl's automatic NUMA placement algorithm, or similar.
>
> I'm putting here in the cover letter a markdown document I wrote to better
> describe my findings and ideas (sorry if it's a bit long! :-D). You can also
> fetch it at the following links:
>
>  * http://xenbits.xen.org/people/dariof/CMT-in-scheduling.pdf
>  * http://xenbits.xen.org/people/dariof/CMT-in-scheduling.markdown
>
> See the document itself and the changelog of the various patches for details.
>
> The series includes one Chao's patch on top, as I found it convenient to build
> on top of it. The series itself is available here:
>
>   git://xenbits.xen.org/people/dariof/xen.git  wip/sched/icachemon
>   http://xenbits.xen.org/gitweb/?p=people/dariof/xen.git;a=shortlog;h=refs/heads/wip/sched/icachemon
>
> Thanks a lot to everyone that will read and reply! :-)
>
> Regards,
> Dario
> ---

There seem to be several areas of confusion indicated in your document. 
I am unsure whether this is a side effect of the way you have written
it, but here are (hopefully) some words of clarification.  To the best
of my knowledge:

PSR CMT works by tagging cache lines with the currently-active RMID. 
The cache utilisation is a count of the number of lines which are tagged
with a specific RMID.  MBM on the other hand counts the number of cache
line fills and cache line evictions tagged with a specific RMID.

By this nature, the information will never reveal the exact state of
play.  e.g. a core with RMID A which gets a cache line hit against a
line currently tagged with RMID B will not alter any accounting. 
Furthermore, as alterations of the RMID only occur in
__context_switch(), Xen actions such as handling an interrupt will be
accounted against the currently active domain (or other future
granularity of RMID).

"max_rmid" is a per-socket property.  There is no requirement for it to
be the same for each socket in a system, although it is likely, given a
homogeneous system.  The limit on RMID is based on the size of the
accounting table.

As far as MSRs themselves go, an extra MSR write in the context switch
path is likely to pale into the noise.  However, querying the data is an
indirect MSR read (write to the event select MSR, read from  the data
MSR).  Furthermore there is no way to atomically read all data at once
which means that activity on other cores can interleave with
back-to-back reads in the scheduler.


As far as the plans here go, I have some concerns.  PSR is only
available on server platforms, which will be 2/4 socket systems with
large numbers of cores.  As you have discovered, there insufficient
RMIDs for redbrick pcpus, and on a system that size, XenServer typically
gets 7x vcpus to pcpus.

I think it is unrealistic to expect to use any scheduler scheme which is
per-pcpu or per-vcpu while the RMID limit is as small as it is. 
Depending on workload, even a per-domain scheme might be problematic. 
One of our tests involves running 500xWin7 VMs on that particular box.

~Andrew

  parent reply	other threads:[~2015-04-07 10:27 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-04  2:14 [RFC PATCH 0/7] Intel Cache Monitoring: Current Status and Future Opportunities Dario Faggioli
2015-04-04  2:14 ` [RFC PATCH 1/7] x86: improve psr scheduling code Dario Faggioli
2015-04-06 13:48   ` Konrad Rzeszutek Wilk
2015-04-04  2:14 ` [RFC PATCH 2/7] Xen: x86: print max usable RMID during init Dario Faggioli
2015-04-06 13:48   ` Konrad Rzeszutek Wilk
2015-04-07 10:11     ` Dario Faggioli
2015-04-04  2:14 ` [RFC PATCH 3/7] xen: psr: reserve an RMID for each core Dario Faggioli
2015-04-06 13:59   ` Konrad Rzeszutek Wilk
2015-04-07 10:19     ` Dario Faggioli
2015-04-07 13:57       ` Konrad Rzeszutek Wilk
2015-04-07  8:24   ` Chao Peng
2015-04-07 10:07     ` Dario Faggioli
2015-04-08 13:28   ` George Dunlap
2015-04-08 14:03     ` Dario Faggioli
2015-04-04  2:14 ` [RFC PATCH 4/7] xen: libxc: libxl: report per-CPU cache occupancy up to libxl Dario Faggioli
2015-04-04  2:14 ` [RFC PATCH 5/7] xen: libxc: libxl: allow for attaching and detaching a CPU to CMT Dario Faggioli
2015-04-04  2:15 ` [RFC PATCH 6/7] xl: report per-CPU cache occupancy up to libxl Dario Faggioli
2015-04-04  2:15 ` [RFC PATCH 7/7] xl: allow for attaching and detaching a CPU to CMT Dario Faggioli
2015-04-07  8:19 ` [RFC PATCH 0/7] Intel Cache Monitoring: Current Status and Future Opportunities Chao Peng
2015-04-07  9:51   ` Dario Faggioli
2015-04-07 10:27 ` Andrew Cooper [this message]
2015-04-07 13:10   ` Dario Faggioli
2015-04-08  5:59     ` Chao Peng
2015-04-08  8:23       ` Dario Faggioli
2015-04-08  8:53         ` Andrew Cooper
2015-04-08  8:55         ` Chao Peng
2015-04-09 15:44     ` Meng Xu
2015-04-08 11:27   ` George Dunlap
2015-04-08 13:29     ` Dario Faggioli
2015-04-08 11:30 ` George Dunlap
2015-04-08 13:16   ` Dario Faggioli
2015-04-09 15:37 ` Meng Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5523B0FB.8020509@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=dario.faggioli@citrix.com \
    --cc=dongxiao.xu@intel.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.