From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfQzt-0002ki-N5 for qemu-devel@nongnu.org; Tue, 07 Apr 2015 06:44:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfQzq-0007P2-Hn for qemu-devel@nongnu.org; Tue, 07 Apr 2015 06:44:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45621 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfQzq-0007Oq-Bn for qemu-devel@nongnu.org; Tue, 07 Apr 2015 06:44:42 -0400 Message-ID: <5523B518.5050902@suse.de> Date: Tue, 07 Apr 2015 12:44:40 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1427932716-11800-1-git-send-email-namit@cs.technion.ac.il> <551D3768.9090404@redhat.com> <5523AE38.6000701@suse.de> <5523B2C6.5080601@redhat.com> In-Reply-To: <5523B2C6.5080601@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] target-i386: clear bsp bit when designating bsp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: rth@twiddle.net, mst@redhat.com, nadav.amit@gmail.com, Eduardo Habkost , Nadav Amit Am 07.04.2015 um 12:34 schrieb Paolo Bonzini: > On 07/04/2015 12:15, Andreas F=E4rber wrote: >>>>>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c >>>>>> index b2d1c95..03b33cf 100644 >>>>>> --- a/target-i386/cpu.c >>>>>> +++ b/target-i386/cpu.c >>>>>> @@ -2714,9 +2714,7 @@ static void x86_cpu_reset(CPUState *s) >>>>>> =20 >>>>>> #if !defined(CONFIG_USER_ONLY) >>>>>> /* We hard-wire the BSP to the first CPU. */ >>>>>> - if (s->cpu_index =3D=3D 0) { >>>>>> - apic_designate_bsp(cpu->apic_state); >>>>>> - } >>>>>> + apic_designate_bsp(cpu->apic_state, s->cpu_index =3D=3D 0); >>>>>> =20 >>>>>> s->halted =3D !cpu_is_bsp(cpu); >>>>>> =20 >>>>>> >>>> >>>> Thanks, applied locally. >> I don't understand why this is necessary: The cpu_index doesn't change= , >> therefore the BSP designation won't change either. >=20 > It can change at runtime, though, if you're using the KVM in-kernel LAP= IC. Got a pointer? A quick git-grep doesn't show anything in hw/ or kvm-all.c or target-i386/ assigning cpu_index, so it'll always have the initial value. Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)