From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm64: Use virtual address when setting up early_printk fixmap Date: Tue, 7 Apr 2015 12:07:28 +0100 Message-ID: <5523BA70.1040701@citrix.com> References: <1428392004-11482-1-git-send-email-cbz@baozis.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1428392004-11482-1-git-send-email-cbz@baozis.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chen Baozi , xen-devel@lists.xen.org Cc: Chen Baozi , julien.grall@linaro.org, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Chen, On 07/04/2015 08:33, Chen Baozi wrote: > From: Chen Baozi > > We have already had the boot pagetable when reaching the point > of early_printk fixmap setup. Thus there is no longer necessary > to caculate physical address of xen_fixmap. s/caculate/calculate/ OOI, is it a bug or a clean up? > > Signed-off-by: Chen Baozi > --- > xen/arch/arm/arm64/head.S | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 75b7ee1..a2ac2d4 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -520,7 +520,6 @@ paging: > > /* Add UART to the fixmap table */ > ldr x1, =xen_fixmap > - add x1, x1, x20 /* x1 := paddr (xen_fixmap) */ You need to add a comment on "ldr x1..." in order to explain what x1 contains. i.e /* x1 := vaddr (xen_fixmap) */ Regards, -- Julien Grall