Re: [PATCH] libfdt/tests: Add fdt_path_offset_namelen() test

[Peter Hurley <peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>]

On 04/07/2015 12:49 AM, David Gibson wrote:
> On Sun, Apr 05, 2015 at 12:05:56AM -0400, Peter Hurley wrote:
>> Add unit test for fdt_path_offset_namelen(). Verify partial path-
>> descending retrieves the same node offset as fdt_subnode_offset().
>> Verify parsing correctness with multiple path separators, both
>> mid-path and trailing.
> 
> Thanks for writing this.  However, looking at it, I find the way it's
> doing the path splitting a bit impenetrable, and overly tied to the
> expected usecase of fdt_path_offset_namelen() rather than just its
> defined semantics.

Yeah; those are remnants of the unsubmitted v1, which retrieved the
paths from the fdt itself, as I wrote in the other thread.

> Instead of merging this, I've merged your original
> fdt_path_offset_namelen() patch, plus several patches which extend the
> existing path_offset testcase to exercise fdt_path_offset_namelen()
> and cover some other edge cases.

Ok, those look fine.

> I did spot a case where the existing code is arguably incorrect: using
> fdt_path_offset_namelen(fdt, "/somenode\0foo", 13) will return the
> same as fdt_path_offset(fdt, "/somenode"), although I think ideally it
> should always return -FDT_ERR_NOTFOUND, or some other error, since
> node names can never include \0.

Ok, I'll fix that.

> That's not an important enough problem to delay the patch though.  So,
> fdt_path_offset_namelen() is merged and pushed up to the usual git
> tree on kernel.org.

Thanks.

Regards,
Peter Hurley

--
To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html