From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: vmx: pass error code with internal error #2 Date: Tue, 07 Apr 2015 13:16:52 +0200 Message-ID: <5523BCA4.4070601@redhat.com> References: <1428001865-32280-1-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59069 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751528AbbDGLRH (ORCPT ); Tue, 7 Apr 2015 07:17:07 -0400 In-Reply-To: <1428001865-32280-1-git-send-email-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/04/2015 21:11, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > Exposing the on-stack error code with internal error is cheap and > potentially useful. >=20 > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > --- > arch/x86/kvm/vmx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 0caaf56eb459..cfbd737afcd1 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -5089,9 +5089,10 @@ static int handle_exception(struct kvm_vcpu *v= cpu) > !(is_page_fault(intr_info) && !(error_code & PFERR_RSVD_MASK)))= { > vcpu->run->exit_reason =3D KVM_EXIT_INTERNAL_ERROR; > vcpu->run->internal.suberror =3D KVM_INTERNAL_ERROR_SIMUL_EX; > - vcpu->run->internal.ndata =3D 2; > + vcpu->run->internal.ndata =3D 3; > vcpu->run->internal.data[0] =3D vect_info; > vcpu->run->internal.data[1] =3D intr_info; > + vcpu->run->internal.data[2] =3D error_code; > return 0; > } > =20 >=20 Applied, thanks. Paolo