From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: [PATCH v3 3/4] target: Correct a comment Date: Tue, 7 Apr 2015 14:33:52 +0200 Message-ID: <5523CEB0.2020101@sandisk.com> References: <5523CE55.3090401@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bl2on0058.outbound.protection.outlook.com ([65.55.169.58]:60002 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751528AbbDGMeA (ORCPT ); Tue, 7 Apr 2015 08:34:00 -0400 In-Reply-To: <5523CE55.3090401@sandisk.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Christoph Hellwig , "Nicholas A. Bellinger" , Hannes Reinecke , Mike Christie , "linux-scsi@vger.kernel.org" , target-devel Correct the comment above the definition of TCM_MAX_COMMAND_SIZE. A quote from Christoph: There aren't any legacy issues, we just decided to handle > 16 byte CDBs in the slow path. Signed-off-by: Bart Van Assche Cc: Nicholas Bellinger Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Mike Christie --- include/target/target_core_base.h | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index 672150b..7a6e55f 100644 --- a/include/target/target_core_base.h +++ b/include/target/target_core_base.h @@ -17,16 +17,8 @@ /* Don't raise above 511 or REPORT_LUNS needs to handle >1 page */ #define TRANSPORT_MAX_LUNS_PER_TPG 256 /* - * By default we use 32-byte CDBs in TCM Core and subsystem plugin code. - * - * Note that both include/scsi/scsi_cmnd.h:MAX_COMMAND_SIZE and - * include/linux/blkdev.h:BLOCK_MAX_CDB as of v2.6.36-rc4 still use - * 16-byte CDBs by default and require an extra allocation for - * 32-byte CDBs to because of legacy issues. - * - * Within TCM Core there are no such legacy limitiations, so we go ahead - * use 32-byte CDBs by default and use include/scsi/scsi.h:scsi_command_size() - * within all TCM Core and subsystem plugin code. + * Maximum size of a CDB that can be stored in se_cmd without allocating + * memory dynamically for the CDB. */ #define TCM_MAX_COMMAND_SIZE 32 /* -- 2.1.4