* [PATCH] drm/exynos: dsi: remove the empty mode_valid callback
@ 2015-04-02 9:52 Hyungwon Hwang
2015-04-02 10:34 ` Andrzej Hajda
2015-04-07 13:32 ` Inki Dae
0 siblings, 2 replies; 3+ messages in thread
From: Hyungwon Hwang @ 2015-04-02 9:52 UTC (permalink / raw)
To: dri-devel, inki.dae; +Cc: cw00.choi, sw0312.kim, Hyungwon Hwang
Because the helper function which calls this callback checks whether
it is registered or not. It is not necessary if it does nothing.
So it would be better to remove the function for clarity.
Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 05fe93d..0492715 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1473,12 +1473,6 @@ static int exynos_dsi_get_modes(struct drm_connector *connector)
return 0;
}
-static int exynos_dsi_mode_valid(struct drm_connector *connector,
- struct drm_display_mode *mode)
-{
- return MODE_OK;
-}
-
static struct drm_encoder *
exynos_dsi_best_encoder(struct drm_connector *connector)
{
@@ -1489,7 +1483,6 @@ exynos_dsi_best_encoder(struct drm_connector *connector)
static struct drm_connector_helper_funcs exynos_dsi_connector_helper_funcs = {
.get_modes = exynos_dsi_get_modes,
- .mode_valid = exynos_dsi_mode_valid,
.best_encoder = exynos_dsi_best_encoder,
};
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/exynos: dsi: remove the empty mode_valid callback
2015-04-02 9:52 [PATCH] drm/exynos: dsi: remove the empty mode_valid callback Hyungwon Hwang
@ 2015-04-02 10:34 ` Andrzej Hajda
2015-04-07 13:32 ` Inki Dae
1 sibling, 0 replies; 3+ messages in thread
From: Andrzej Hajda @ 2015-04-02 10:34 UTC (permalink / raw)
To: Hyungwon Hwang, dri-devel, inki.dae; +Cc: cw00.choi, sw0312.kim
On 04/02/2015 11:52 AM, Hyungwon Hwang wrote:
> Because the helper function which calls this callback checks whether
> it is registered or not. It is not necessary if it does nothing.
> So it would be better to remove the function for clarity.
>
> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index 05fe93d..0492715 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1473,12 +1473,6 @@ static int exynos_dsi_get_modes(struct drm_connector *connector)
> return 0;
> }
>
> -static int exynos_dsi_mode_valid(struct drm_connector *connector,
> - struct drm_display_mode *mode)
> -{
> - return MODE_OK;
> -}
> -
> static struct drm_encoder *
> exynos_dsi_best_encoder(struct drm_connector *connector)
> {
> @@ -1489,7 +1483,6 @@ exynos_dsi_best_encoder(struct drm_connector *connector)
>
> static struct drm_connector_helper_funcs exynos_dsi_connector_helper_funcs = {
> .get_modes = exynos_dsi_get_modes,
> - .mode_valid = exynos_dsi_mode_valid,
> .best_encoder = exynos_dsi_best_encoder,
> };
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/exynos: dsi: remove the empty mode_valid callback
2015-04-02 9:52 [PATCH] drm/exynos: dsi: remove the empty mode_valid callback Hyungwon Hwang
2015-04-02 10:34 ` Andrzej Hajda
@ 2015-04-07 13:32 ` Inki Dae
1 sibling, 0 replies; 3+ messages in thread
From: Inki Dae @ 2015-04-07 13:32 UTC (permalink / raw)
To: Hyungwon Hwang; +Cc: cw00.choi, sw0312.kim, dri-devel
On 2015년 04월 02일 18:52, Hyungwon Hwang wrote:
> Because the helper function which calls this callback checks whether
> it is registered or not. It is not necessary if it does nothing.
> So it would be better to remove the function for clarity.
Applied.
Thanks,
Inki Dae
>
> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index 05fe93d..0492715 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1473,12 +1473,6 @@ static int exynos_dsi_get_modes(struct drm_connector *connector)
> return 0;
> }
>
> -static int exynos_dsi_mode_valid(struct drm_connector *connector,
> - struct drm_display_mode *mode)
> -{
> - return MODE_OK;
> -}
> -
> static struct drm_encoder *
> exynos_dsi_best_encoder(struct drm_connector *connector)
> {
> @@ -1489,7 +1483,6 @@ exynos_dsi_best_encoder(struct drm_connector *connector)
>
> static struct drm_connector_helper_funcs exynos_dsi_connector_helper_funcs = {
> .get_modes = exynos_dsi_get_modes,
> - .mode_valid = exynos_dsi_mode_valid,
> .best_encoder = exynos_dsi_best_encoder,
> };
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-07 13:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-02 9:52 [PATCH] drm/exynos: dsi: remove the empty mode_valid callback Hyungwon Hwang
2015-04-02 10:34 ` Andrzej Hajda
2015-04-07 13:32 ` Inki Dae
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.