From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfVBF-00067Y-54 for qemu-devel@nongnu.org; Tue, 07 Apr 2015 11:12:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfVB9-00084S-9H for qemu-devel@nongnu.org; Tue, 07 Apr 2015 11:12:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfVB9-000847-0f for qemu-devel@nongnu.org; Tue, 07 Apr 2015 11:12:39 -0400 Message-ID: <5523F3B9.6050107@redhat.com> Date: Tue, 07 Apr 2015 09:11:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428003106-20754-1-git-send-email-eblake@redhat.com> <20150407124651.GA30085@igalia.com> In-Reply-To: <20150407124651.GA30085@igalia.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EpCB2UeRrt9Bu90UJCaTBd4VxN7eOGq2k" Subject: Re: [Qemu-devel] [PATCH] qapi: Accept 'null' in QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: kwolf@redhat.com, armbru@redhat.com, akong@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EpCB2UeRrt9Bu90UJCaTBd4VxN7eOGq2k Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/07/2015 06:46 AM, Alberto Garcia wrote: > On Thu, Apr 02, 2015 at 01:31:46PM -0600, Eric Blake wrote: >=20 >> So instead, this patch creates a new QObject subtype: QNull. >=20 > The code looks good, but Markus's approach of using a single instance > seems probably a bit better for this case. It's what we get for both independently tackling the same problem. I still plan to review Markus' series, and might post an updated version that takes the best of our two approaches. >=20 >> --- /dev/null >> +++ b/include/qapi/qmp/qnull.h >> @@ -0,0 +1,23 @@ >> +/* >> + * QBool Module >=20 > You probably meant QNull here. My blatant use of copy-and-paste shines through :) I'll certainly fix that, if my approach is still worth using. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EpCB2UeRrt9Bu90UJCaTBd4VxN7eOGq2k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVI/O5AAoJEKeha0olJ0NqRawH/ism77vYIblrsuKmAJdGAofE zLUedX4YfSFlRbzUYEc2MFJ1pDHEROSKDCPGK9+j1CxGCswP8iSJAfMpLG9jPqjR CLT45XJoMHus9cLXH8dMPSqtMrdYFXg/1zYSUFiqhgaPY+WI7iVx+Mq0vd45TXbW FmrIqxCvWt1mtKsJnyNOjAMSYOl/m1FVc5f0m76/fLoYDnazxhgzEj6JX4U7Jyu3 8ttwfPoDCtbgAYkZfiDivI6NuVNvNNc4sjL5sYltWVQTCQacXgGSvS7R/dBFRfyf AA6h2hGCkoGb+NHzvgkxVInhsrvwtw8VHYiN/rRwKgKc+H4sI7M/R0vuWpBWK+A= =Sdeb -----END PGP SIGNATURE----- --EpCB2UeRrt9Bu90UJCaTBd4VxN7eOGq2k--