From: Paolo Bonzini <pbonzini@redhat.com>
To: Bandan Das <bsd@redhat.com>
Cc: Nadav Amit <namit@cs.technion.ac.il>, kvm@vger.kernel.org
Subject: Re: [PATCH v2 1/4] KVM: x86: INIT and reset sequences are different
Date: Tue, 07 Apr 2015 18:22:17 +0200 [thread overview]
Message-ID: <55240439.4060103@redhat.com> (raw)
In-Reply-To: <jpgmw2j6hhc.fsf@redhat.com>
On 07/04/2015 18:17, Bandan Das wrote:
> > I think a bool argument is good enough. QEMU has different functions,
> > and init ends up doing save/reset/restore which is pretty ugly.
>
> Right, I meant that init could just be a wrapper so that it atleast shows up in
> a backtrace - could be helpful for debugging.
I suspect that the compiler would inline any sensible implementation and
it wouldn't show up in the backtraces. :(
Paolo
next prev parent reply other threads:[~2015-04-07 16:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 0:10 [PATCH v2 0/4] KVM: x86: Reset fixes Nadav Amit
2015-04-02 0:10 ` [PATCH v2 1/4] KVM: x86: INIT and reset sequences are different Nadav Amit
2015-04-02 2:17 ` Bandan Das
2015-04-07 13:23 ` Paolo Bonzini
2015-04-07 16:17 ` Bandan Das
2015-04-07 16:22 ` Paolo Bonzini [this message]
2015-04-07 16:35 ` Bandan Das
2015-04-07 13:23 ` Paolo Bonzini
2015-04-07 13:57 ` Paolo Bonzini
2015-04-02 0:10 ` [PATCH v2 2/4] KVM: x86: BSP in MSR_IA32_APICBASE is writable Nadav Amit
2015-04-02 0:10 ` [PATCH v2 3/4] KVM: x86: DR0-DR3 are not clear on reset Nadav Amit
2015-04-02 0:10 ` [PATCH v2 4/4] KVM: x86: Clear CR2 on VCPU reset Nadav Amit
2015-04-14 10:03 ` Wanpeng Li
2015-04-14 10:31 ` Nadav Amit
2015-04-07 14:01 ` [PATCH v2 0/4] KVM: x86: Reset fixes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55240439.4060103@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=namit@cs.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.