From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v6 2/5] sysctl: Add sysctl interface for querying PCI topology Date: Tue, 07 Apr 2015 13:05:43 -0400 Message-ID: <55240E67.1060005@oracle.com> References: <1428358329-8466-1-git-send-email-boris.ostrovsky@oracle.com> <1428358329-8466-3-git-send-email-boris.ostrovsky@oracle.com> <5524013E.7010507@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5524013E.7010507@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , ian.jackson@eu.citrix.com, ian.campbell@citrix.com, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, dgdegra@tycho.nsa.gov, jbeulich@suse.com, keir@xen.org Cc: elena.ufimtseva@oracle.com, dario.faggioli@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 04/07/2015 12:09 PM, Andrew Cooper wrote: > On 06/04/15 23:12, Boris Ostrovsky wrote: >> Signed-off-by: Boris Ostrovsky >> --- >> >> Changes in v6: >> * Dropped continuations, the sysctl now returns after 64 iteration if necessary > Why? The caller should reasonably expect a single hypercall to complete, > not to have to reissue repeated to get all the data they want. The caller is expected to restart from first_dev, not from beginning. > >> * -ENODEV returned if device is not found > You don't actually break on -ENODEV, which causes the loop to continue > to new devices and leave no hint as to which device doesn't exist. Doh, I must have lost the break during various merges. -boris