Re: [PATCH net-next 1/4] via-rhine: commit receive buffer address before descriptor status update.

[Alexander Duyck <alexander.h.duyck@redhat.com>]

On 04/06/2015 11:01 AM, Francois Romieu wrote:
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
> ---
>   drivers/net/ethernet/via/via-rhine.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c
> index a191afc..00fea3d 100644
> --- a/drivers/net/ethernet/via/via-rhine.c
> +++ b/drivers/net/ethernet/via/via-rhine.c
> @@ -2063,6 +2063,7 @@ static int rhine_rx(struct net_device *dev, int limit)
>   				break;
>   			}
>   			rp->rx_ring[entry].addr = cpu_to_le32(rp->rx_skbuff_dma[entry]);
> +			wmb();
>   		}
>   		rp->rx_ring[entry].rx_status = cpu_to_le32(DescOwn);
>   	}

Do you need a full wmb() here or would a dma_wmb() be enough?  It could 
make a difference on some processor architectures.

- Alex