All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
	linux-kernel@vger.kernel.org
Cc: hch@lst.de, linux-block@vger.kernel.org
Subject: Re: [PATCHv2 0/4] blk_execute_rq{_nowait} cleanup part1
Date: Sun, 11 Aug 2019 07:47:17 -0600	[thread overview]
Message-ID: <55246cff-6d32-e7d5-bee0-9940bc59250a@kernel.dk> (raw)
In-Reply-To: <20190809105433.8946-1-marcos.souza.org@gmail.com>

On 8/9/19 3:54 AM, Marcos Paulo de Souza wrote:
> After checking the request_queue argument of funtion blk_execute_rq_nowait, I
> now added three more patches, one to remove the same argument from
> blk_execute_rq and other two to change the at_head argument from
> blk_exeute_rq_{nowait} from int to bool.
> 
> Original patch can be checked here[1].
> 
> After this patch gets merged, my plan is to analyse the usage the gendisk
> argument, is being set as NULL but the majority of callers.
> 
> [1]: https://lkml.org/lkml/2019/8/6/31

Don't ever send something out that hasn't even been compiled. I already
detest doing kernel-wide cleanup changes like this, but when I do, I
need absolute confidence in it actually being tested. The fact that it
hasn't even been compiled is a big black mark on the submitter.

-- 
Jens Axboe


  parent reply	other threads:[~2019-08-11 13:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09 10:54 [PATCHv2 0/4] blk_execute_rq{_nowait} cleanup part1 Marcos Paulo de Souza
2019-08-09 10:54 ` [PATCHv2 1/4] block: Remove request_queue argument from blk_execute_rq_nowait Marcos Paulo de Souza
2019-08-09 10:54   ` Marcos Paulo de Souza
2019-08-09 10:54   ` Marcos Paulo de Souza
2019-08-09 10:54   ` Marcos Paulo de Souza
2019-08-09 10:54 ` [PATCHv2 2/4] fs/block/drivers: Remove request_queue argument from blk_execute_rq Marcos Paulo de Souza
2019-08-09 10:54   ` Marcos Paulo de Souza
2019-08-09 10:54 ` [PATCHv2 3/4] block: Change at_head argument of blk_execute_rq_nowait to bool Marcos Paulo de Souza
2019-08-09 10:54   ` Marcos Paulo de Souza
2019-08-09 10:54   ` Marcos Paulo de Souza
2019-08-09 10:54 ` [PATCHv2 4/4] block: Change at_head argument of blk_execute_rq " Marcos Paulo de Souza
2019-08-09 10:54   ` Marcos Paulo de Souza
2019-08-11  5:20   ` kbuild test robot
2019-08-11  5:20     ` kbuild test robot
2019-08-11 13:47 ` Jens Axboe [this message]
2019-08-14  2:05   ` [PATCHv2 0/4] blk_execute_rq{_nowait} cleanup part1 Marcos Paulo de Souza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55246cff-6d32-e7d5-bee0-9940bc59250a@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcos.souza.org@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.