From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xose Vazquez Perez <xose.vazquez@gmail.com>
Subject: Re: [PATCH 1/2] Remove duplicate hwtable entry for
	XtremIO
Date: Wed, 08 Apr 2015 11:46:54 +0200
Message-ID: <5524F90E.9080402@gmail.com>
References: <1427696603-15184-1-git-send-email-hare@suse.de>
Reply-To: device-mapper development <dm-devel@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dm-devel-bounces@redhat.com>
In-Reply-To: <1427696603-15184-1-git-send-email-hare@suse.de>
List-Unsubscribe: <https://www.redhat.com/mailman/options/dm-devel>,
	<mailto:dm-devel-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/dm-devel>
List-Post: <mailto:dm-devel@redhat.com>
List-Help: <mailto:dm-devel-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/dm-devel>,
	<mailto:dm-devel-request@redhat.com?subject=subscribe>
Sender: dm-devel-bounces@redhat.com
Errors-To: dm-devel-bounces@redhat.com
To: Hannes Reinecke <hare@suse.de>, Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: dm-devel@redhat.com, Vincent Chen <vincent.y.chen@emc.com>
List-Id: dm-devel.ids

On 03/30/2015 08:23 AM, Hannes Reinecke wrote:

> Commit b47e607408e1edce3a03744b4aefa292723c7fc6 introduced a new
> hwtable entry for EMC XtremIO instead of updating the existing
> one.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>  libmultipath/hwtable.c | 17 ++---------------
>  1 file changed, 2 insertions(+), 15 deletions(-)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 13611fe..fa4b20f 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -294,11 +294,11 @@ static struct hwentry default_hw[] = {
>  		.product       = "XtremApp",
>  		.features      = DEFAULT_FEATURES,
>  		.hwhandler     = DEFAULT_HWHANDLER,
> +		.selector      = "queue-length 0",
>  		.pgpolicy      = MULTIBUS,
>  		.pgfailback    = FAILBACK_UNDEF,
> -		.rr_weight     = RR_WEIGHT_NONE,
> -		.no_path_retry = 5,
>  		.checker_name  = TUR,
> +		.fast_io_fail  = 5,
>  		.prio_name     = DEFAULT_PRIO,
>  		.prio_args     = NULL,
>  	},
> @@ -1166,19 +1166,6 @@ static struct hwentry default_hw[] = {
>  		.prio_name     = PRIO_ALUA,
>  		.prio_args     = NULL,
>  	},
> -	{
> -		.vendor        = "XtremIO",
> -		.product       = "XtremApp",
> -		.features      = DEFAULT_FEATURES,
> -		.hwhandler     = DEFAULT_HWHANDLER,
> -		.selector      = "queue-length 0",
> -		.pgpolicy      = MULTIBUS,
> -		.pgfailback    = -FAILBACK_IMMEDIATE,
> -		.checker_name  = DIRECTIO,
> -		.fast_io_fail  = 15,
> -		.prio_name     = DEFAULT_PRIO,
> -		.prio_args     = NULL,
> -	},
>  	/*
>  	 * EOL
>  	 */
> 

CC: Vincent Chen <vincent.y.chen@emc.com> and Benjamin Marzinski <bmarzins@redhat.com>
because this patch modifies a previous configuration 83302a2f64ca8ee8dac5d6ac08e8eb8a5e9af343