From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 2/3] blkif: enable multi-page ring supporting Date: Wed, 8 Apr 2015 11:46:44 +0100 Message-ID: <55250714.7070406@citrix.com> References: <1428043501-13912-1-git-send-email-bob.liu@oracle.com> <1428043501-13912-2-git-send-email-bob.liu@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YfnVS-00024b-4V for xen-devel@lists.xenproject.org; Wed, 08 Apr 2015 10:46:50 +0000 In-Reply-To: <1428043501-13912-2-git-send-email-bob.liu@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Bob Liu , xen-devel@lists.xenproject.org Cc: jgross@suse.com, paul.durrant@citrix.com, wei.liu2@citrix.com, david.vrabel@citrix.com, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org On 03/04/15 07:45, Bob Liu wrote: > Remove the 'DEPRECATED' and next patch will follow the protocol defined here to > support multi-page ring. Why are you un-deprecating this instead of using max-ring-page-order? Are you allowing for non power of two counts? If so, the documentation needs to be updated as well. Also num-ring-pages is also tagged as deprecated. Changes in blkif.h need to be made in Xen first. David > --- a/xen/include/public/io/blkif.h > +++ b/xen/include/public/io/blkif.h > @@ -303,7 +303,7 @@ > * Values: > * Default Value: 1 > * Maximum Value: MAX(max-ring-pages,(0x1 << max-ring-page-order)) > - * Notes: DEPRECATED, 2, 3 > + * Notes: 2, 3 > * > * The size of the frontend allocated request ring buffer in units of > * machine pages. The value must be a power of 2. >