diff for duplicates of <5525162C.3020808@bfs.de> diff --git a/a/1.txt b/N1/1.txt index 20c53ad..71bf807 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,15 +3,15 @@ Am 08.04.2015 11:51, schrieb Julia Lawall: >> void ext4_fname_crypto_free_buffer(void **buf) >> { ->> - if (*buf = NULL || IS_ERR(buf)) ->> + if (*buf = NULL || IS_ERR(*buf)) +>> - if (*buf == NULL || IS_ERR(buf)) +>> + if (*buf == NULL || IS_ERR(*buf)) > > Why not use IS_ERR_OR_NULL? > > julia -why test *buf = NULL ? xfree() can handle this. +why test *buf == NULL ? xfree() can handle this. the question is do programm depend on *buf=NULL. In case of IS_ERR(*buf) *buf will be left unchanged diff --git a/a/content_digest b/N1/content_digest index 688f770..22d4260 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\0alpine.DEB.2.10.1504081150401.9503@hadrien\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [patch] ext4 crypto: testing the wrong variable\0" - "Date\0Wed, 08 Apr 2015 11:51:08 +0000\0" + "Date\0Wed, 08 Apr 2015 13:51:08 +0200\0" "To\0Julia Lawall <julia.lawall@lip6.fr>\0" "Cc\0Dan Carpenter <dan.carpenter@oracle.com>" Theodore Ts'o <tytso@mit.edu> @@ -17,15 +17,15 @@ "Am 08.04.2015 11:51, schrieb Julia Lawall:\n" ">> void ext4_fname_crypto_free_buffer(void **buf)\n" ">> {\n" - ">> -\tif (*buf = NULL || IS_ERR(buf))\n" - ">> +\tif (*buf = NULL || IS_ERR(*buf))\n" + ">> -\tif (*buf == NULL || IS_ERR(buf))\n" + ">> +\tif (*buf == NULL || IS_ERR(*buf))\n" "> \n" "> Why not use IS_ERR_OR_NULL?\n" "> \n" "> julia\n" "\n" "\n" - "why test *buf = NULL ? xfree() can handle this.\n" + "why test *buf == NULL ? xfree() can handle this.\n" "\n" "the question is do programm depend on *buf=NULL.\n" "In case of IS_ERR(*buf) *buf will be left unchanged\n" @@ -47,4 +47,4 @@ "> More majordomo info at http://vger.kernel.org/majordomo-info.html\n" > -95cdb504511077e45dd9d3ccfc726e3b7c3696985e175c09b70a74d740271589 +04e8c3cdff6faa099dcf0398c6f77f3dee91c018698486278191101fa4364d4b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.