From: Julien Grall <julien.grall.oss@gmail.com>
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>, xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com,
julien.grall@linaro.org, tim@xen.org,
stefano.stabellini@citrix.com, jbeulich@suse.com, keir@xen.org
Subject: Re: [PATCH V14 2/7] xen/arm: Implement domain_get_maximum_gpfn
Date: Wed, 08 Apr 2015 14:23:38 +0100 [thread overview]
Message-ID: <55252BDA.6000209@gmail.com> (raw)
In-Reply-To: <1427407531-31694-3-git-send-email-tklengyel@sec.in.tum.de>
Hi Tamas,
On 26/03/15 22:05, Tamas K Lengyel wrote:
> From: Julien Grall <julien.grall@linaro.org>
>
> The function domain_get_maximum_gpfn is returning the maximum gpfn ever
> mapped in the guest. We can use d->arch.p2m.max_mapped_gfn for this purpose.
>
> We use this in xenaccess as to avoid the user attempting to set page
> permissions on pages which don't exist for the domain, as a non-arch specific
> sanity check.
FWIW, xc_domain_maximum_gpfn is buggy for ARM64 as a PFN can be encode
with up to 36 bits which doesn't fit on the return code (an int is used).
Although, I don't see any call to xc_domain_maximum_gpfn in memaccess
(tools/tests/memaccess). So is this patch still useful?
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-04-08 13:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 22:05 [PATCH V14 0/7] Mem_access for ARM Tamas K Lengyel
2015-03-26 22:05 ` [PATCH V14 1/7] xen/arm: groundwork for mem_access support on ARM Tamas K Lengyel
2015-04-15 13:39 ` Ian Campbell
2015-03-26 22:05 ` [PATCH V14 2/7] xen/arm: Implement domain_get_maximum_gpfn Tamas K Lengyel
2015-04-08 13:23 ` Julien Grall [this message]
2015-04-08 13:38 ` Tamas K Lengyel
2015-04-08 13:42 ` Julien Grall
2015-04-08 13:47 ` Tamas K Lengyel
2015-04-08 13:49 ` Julien Grall
2015-03-26 22:05 ` [PATCH V14 3/7] xen/arm: Allow hypervisor access to mem_access protected pages Tamas K Lengyel
2015-04-08 14:33 ` Julien Grall
2015-04-08 15:57 ` Tamas K Lengyel
2015-04-08 16:07 ` Julien Grall
2015-04-15 13:48 ` Ian Campbell
2015-04-15 15:36 ` Tamas K Lengyel
2015-04-15 15:45 ` Ian Campbell
2015-04-16 9:04 ` Tim Deegan
2015-03-26 22:05 ` [PATCH V14 4/7] xen/arm: Data abort exception (R/W) mem_access events Tamas K Lengyel
2015-04-08 15:26 ` Julien Grall
2015-04-08 15:45 ` Tamas K Lengyel
2015-04-15 13:53 ` Ian Campbell
2015-03-26 22:05 ` [PATCH V14 5/7] xen/arm: Instruction prefetch abort (X) mem_access event handling Tamas K Lengyel
2015-03-26 23:21 ` Julien Grall
2015-03-27 8:32 ` Tamas K Lengyel
2015-03-27 12:21 ` Julien Grall
2015-03-27 15:52 ` Ian Campbell
2015-03-27 22:18 ` Tamas K Lengyel
2015-03-30 9:41 ` Ian Campbell
2015-03-30 15:14 ` Tamas K Lengyel
2015-03-30 15:24 ` Ian Campbell
2015-03-30 15:28 ` Tamas K Lengyel
2015-03-26 22:05 ` [PATCH V14 6/7] xen/arm: Enable mem_access on ARM Tamas K Lengyel
2015-03-26 22:05 ` [PATCH V14 7/7] tools/libxc: Allocate magic page for mem access " Tamas K Lengyel
2015-04-15 13:36 ` [PATCH V14 0/7] Mem_access for ARM Ian Campbell
2015-04-15 14:47 ` Tamas K Lengyel
2015-04-15 15:04 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55252BDA.6000209@gmail.com \
--to=julien.grall.oss@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@linaro.org \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=tklengyel@sec.in.tum.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.