From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 2/3] blkif: enable multi-page ring supporting
Date: Wed, 8 Apr 2015 15:25:18 +0100
Message-ID: <55253A4E.7070909@citrix.com>
References: <1428043501-13912-1-git-send-email-bob.liu@oracle.com>
	<1428043501-13912-2-git-send-email-bob.liu@oracle.com>
	<55250714.7070406@citrix.com> <20150408142155.GH4146@l.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1Yfqv0-0005Hc-RC
	for xen-devel@lists.xenproject.org; Wed, 08 Apr 2015 14:25:26 +0000
In-Reply-To: <20150408142155.GH4146@l.oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: jgross@suse.com, wei.liu2@citrix.com, paul.durrant@citrix.com, xen-devel@lists.xenproject.org, roger.pau@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 08/04/15 15:21, Konrad Rzeszutek Wilk wrote:
> On Wed, Apr 08, 2015 at 11:46:44AM +0100, David Vrabel wrote:
>> On 03/04/15 07:45, Bob Liu wrote:
>>> Remove the 'DEPRECATED' and next patch will follow the protocol defined here to
>>> support multi-page ring.
>>
>> Why are you un-deprecating this instead of using max-ring-page-order?
>> Are you allowing for non power of two counts? If so, the documentation
>> needs to be updated as well.
>>
>> Also num-ring-pages is also tagged as deprecated.
>>
>> Changes in blkif.h need to be made in Xen first.
> 
> Um, this patch is against Xen tree.

With this being patch #2 in a Linux series no one else is going to
notice this is Xen patch either.

David

>>> --- a/xen/include/public/io/blkif.h
>>> +++ b/xen/include/public/io/blkif.h
>>> @@ -303,7 +303,7 @@
>>>   *      Values:         <uint32_t>
>>>   *      Default Value:  1
>>>   *      Maximum Value:  MAX(max-ring-pages,(0x1 << max-ring-page-order))
>>> - *      Notes:          DEPRECATED, 2, 3
>>> + *      Notes:          2, 3
>>>   *
>>>   *      The size of the frontend allocated request ring buffer in units of
>>>   *      machine pages.  The value must be a power of 2.
>>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel