From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/4] libxenstat: check xc_interface_open
	return value
Date: Wed, 8 Apr 2015 16:21:56 +0100
Message-ID: <55254794.2020806@citrix.com>
References: <1428505275-6563-1-git-send-email-wei.liu2@citrix.com>
	<1428505275-6563-2-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1428505275-6563-2-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
Cc: Charles Arnold <carnold@suse.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 08/04/15 16:01, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Charles Arnold <carnold@suse.com>

The xenstat handle passed around already has an open xc_handle.  That
should be reused rather than opening a new one every time we want to get
a list of domain ids.

~Andrew

> ---
>  tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c b/tools/xenstat/libxenstat/src/xenstat_qmp.c
> index 2cb99e9..f3aeec4 100644
> --- a/tools/xenstat/libxenstat/src/xenstat_qmp.c
> +++ b/tools/xenstat/libxenstat/src/xenstat_qmp.c
> @@ -366,6 +366,8 @@ static xc_domaininfo_t *get_domain_ids(int *num_doms)
>  	if (dominfo == NULL)
>  		return NULL;
>  	xc_handle = xc_interface_open(0,0,0);
> +	if (xc_handle == NULL)
> +		return NULL;
>  	*num_doms = xc_domain_getinfolist(xc_handle, 0, 1024, dominfo);
>  	xc_interface_close(xc_handle);
>  	return dominfo;