From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Liu Subject: Re: [PATCH 2/3] blkif: enable multi-page ring supporting Date: Thu, 09 Apr 2015 09:08:14 +0800 Message-ID: <5525D0FE.6030100@oracle.com> References: <1428043501-13912-1-git-send-email-bob.liu@oracle.com> <1428043501-13912-2-git-send-email-bob.liu@oracle.com> <55250714.7070406@citrix.com> <20150408142155.GH4146@l.oracle.com> <55253A4E.7070909@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Yg0xF-0001jZ-Nb for xen-devel@lists.xenproject.org; Thu, 09 Apr 2015 01:08:25 +0000 In-Reply-To: <55253A4E.7070909@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: jgross@suse.com, wei.liu2@citrix.com, paul.durrant@citrix.com, xen-devel@lists.xenproject.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/08/2015 10:25 PM, David Vrabel wrote: > On 08/04/15 15:21, Konrad Rzeszutek Wilk wrote: >> On Wed, Apr 08, 2015 at 11:46:44AM +0100, David Vrabel wrote: >>> On 03/04/15 07:45, Bob Liu wrote: >>>> Remove the 'DEPRECATED' and next patch will follow the protocol defined here to >>>> support multi-page ring. >>> >>> Why are you un-deprecating this instead of using max-ring-page-order? >>> Are you allowing for non power of two counts? If so, the documentation >>> needs to be updated as well. >>> >>> Also num-ring-pages is also tagged as deprecated. >>> >>> Changes in blkif.h need to be made in Xen first. >> >> Um, this patch is against Xen tree. > > With this being patch #2 in a Linux series no one else is going to > notice this is Xen patch either. > Sorry, I'll separate this one. Could you please also review the [PATCH v3 3/3] xen/block: add multi-page ring support? Thanks, -Bob