From: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
To: Darren Hart <dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Darren Hart <dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>,
Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Davidlohr Bueso <dave-h16yJtLeMjHk1uMJSBkQmQ@public.gmane.org>,
KOSAKI Motohiro
<kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>,
Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Subject: Re: [GIT PULL] selftest: Add futex functional tests
Date: Wed, 08 Apr 2015 23:41:52 -0600 [thread overview]
Message-ID: <55261120.7040902@osg.samsung.com> (raw)
In-Reply-To: <20150408041257.GC14618-JIrPihikzLEQaXB9iyTzyw@public.gmane.org>
On 04/07/2015 10:12 PM, Darren Hart wrote:
> On Tue, Mar 31, 2015 at 10:37:51AM -0600, Shuah Khan wrote:
>> On 03/31/2015 10:24 AM, Darren Hart wrote:
>>> On 3/31/15, 8:32 AM, "Shuah Khan" <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> wrote:
>>>
>>>> Hi Daren,
>>>>
>>>> On 03/27/2015 04:17 PM, Darren Hart wrote:
>>>>> Hi Shuah,
>>>>>
>>>>> This series begins the process of migrating my futextest tests into
>>>>> kselftest.
>>>>> I've started with only the functional tests, as the performance and
>>>>> stress may
>>>>> not be appropriate for kselftest as they stand.
>>>>>
>>>>> I cleaned up various complaints from checkpatch, but I ignored others
>>>>> that would
>>>>> require significant rework of the testcases, such as not using volatile
>>>>> and not
>>>>> creating new typedefs.
>>>>>
>>>>> The patches will follow, but I'm providing a pull request for your
>>>>> convenience
>>>>> as well.
>>>>
>>>> Thanks for acting on this so quickly after we talked about it at ELC.
>>>> Just a quick note that I am going to get to this soon once I get the
>>>> 4.1 content wrapped up. We can plan upon getting these into 4.2.
>>>
>>> OK. Michael E. provided some feedback which I can either incorporate and
>>> respin, or I can send as a follow-on to your -next after you merge these.
>>> Which do you prefer?
>>>
>
> ...
>
>> You can wait to re-do patches. I am planning to review the
>> patch set later on this week. That way you can avoid re-spin
>> just in case, I have other comments.
>
> Hi Shuah,
>
> Did you have any additional comments for the futex tests?
>
> Thanks,
>
Sorry Daren. I got called away on a family emergency. The patch
looks good to me and I don't have any additional comments.
Assume these get pulled in for 4.2 release. I will get to them
soon once the 4.1-rc1 is out.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978
WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <shuahkh@osg.samsung.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Darren Hart <dvhart@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-api@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Davidlohr Bueso <dave@stgolabs.net>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
greg Kroah-Hartman <gregkh@linuxfoundation.org>,
fengguang.wu@intel.com, Michael Ellerman <mpe@ellerman.id.au>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [GIT PULL] selftest: Add futex functional tests
Date: Wed, 08 Apr 2015 23:41:52 -0600 [thread overview]
Message-ID: <55261120.7040902@osg.samsung.com> (raw)
In-Reply-To: <20150408041257.GC14618@fury.dvhart.com>
On 04/07/2015 10:12 PM, Darren Hart wrote:
> On Tue, Mar 31, 2015 at 10:37:51AM -0600, Shuah Khan wrote:
>> On 03/31/2015 10:24 AM, Darren Hart wrote:
>>> On 3/31/15, 8:32 AM, "Shuah Khan" <shuahkh@osg.samsung.com> wrote:
>>>
>>>> Hi Daren,
>>>>
>>>> On 03/27/2015 04:17 PM, Darren Hart wrote:
>>>>> Hi Shuah,
>>>>>
>>>>> This series begins the process of migrating my futextest tests into
>>>>> kselftest.
>>>>> I've started with only the functional tests, as the performance and
>>>>> stress may
>>>>> not be appropriate for kselftest as they stand.
>>>>>
>>>>> I cleaned up various complaints from checkpatch, but I ignored others
>>>>> that would
>>>>> require significant rework of the testcases, such as not using volatile
>>>>> and not
>>>>> creating new typedefs.
>>>>>
>>>>> The patches will follow, but I'm providing a pull request for your
>>>>> convenience
>>>>> as well.
>>>>
>>>> Thanks for acting on this so quickly after we talked about it at ELC.
>>>> Just a quick note that I am going to get to this soon once I get the
>>>> 4.1 content wrapped up. We can plan upon getting these into 4.2.
>>>
>>> OK. Michael E. provided some feedback which I can either incorporate and
>>> respin, or I can send as a follow-on to your -next after you merge these.
>>> Which do you prefer?
>>>
>
> ...
>
>> You can wait to re-do patches. I am planning to review the
>> patch set later on this week. That way you can avoid re-spin
>> just in case, I have other comments.
>
> Hi Shuah,
>
> Did you have any additional comments for the futex tests?
>
> Thanks,
>
Sorry Daren. I got called away on a family emergency. The patch
looks good to me and I don't have any additional comments.
Assume these get pulled in for 4.2 release. I will get to them
soon once the 4.1-rc1 is out.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-04-09 5:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 22:17 [GIT PULL] selftest: Add futex functional tests Darren Hart
2015-03-27 22:17 ` Darren Hart
[not found] ` <cover.1427493640.git.dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-27 22:17 ` [PATCH 1/5] selftests: " Darren Hart
2015-03-27 22:17 ` Darren Hart
[not found] ` <597c9eabcac5da9456d6cfd6de9117591d73385e.1427493640.git.dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-05-06 17:28 ` Shuah Khan
2015-05-06 17:28 ` Shuah Khan
[not found] ` <554A4F3A.7020504-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-05-06 18:04 ` Darren Hart
2015-05-06 18:04 ` Darren Hart
2015-03-27 22:17 ` [PATCH 2/5] selftest/futex: Update Makefile to use lib.mk Darren Hart
[not found] ` <95d599bc531666252f8e3f4e467d5f94af2a7ad2.1427493640.git.dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-29 23:49 ` Michael Ellerman
2015-03-29 23:49 ` Michael Ellerman
[not found] ` <1427672978.4218.3.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-03-30 16:31 ` Darren Hart
2015-03-30 16:31 ` Darren Hart
[not found] ` <D13EC750.C43E1%dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-31 23:28 ` Michael Ellerman
2015-03-31 23:28 ` Michael Ellerman
2015-03-27 22:17 ` [PATCH 3/5] selftest/futex: Increment ksft pass and fail counters Darren Hart
2015-03-27 22:17 ` [PATCH 4/5] selftest: Add futex tests to the top-level Makefile Darren Hart
2015-03-27 22:17 ` [PATCH 5/5] kselftest: Add exit code defines Darren Hart
[not found] ` <43a448183a340b61d91c711da4a75898e3ffd8f2.1427493640.git.dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-27 22:59 ` Michael Ellerman
2015-03-27 22:59 ` Michael Ellerman
2015-03-27 23:09 ` Darren Hart
[not found] ` <5515E323.1070800-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-29 23:44 ` Michael Ellerman
2015-03-29 23:44 ` Michael Ellerman
[not found] ` <1427672690.4218.1.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-03-30 16:26 ` Darren Hart
2015-03-30 16:26 ` Darren Hart
[not found] ` <D13EC710.C43DF%dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-30 16:30 ` Peter Zijlstra
2015-03-30 16:30 ` Peter Zijlstra
[not found] ` <551ABE00.9050003@osg.samsung.com>
[not found] ` <551ABE00.9050003-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-03-31 16:24 ` [GIT PULL] selftest: Add futex functional tests Darren Hart
2015-03-31 16:24 ` Darren Hart
2015-03-31 16:37 ` Shuah Khan
[not found] ` <551ACD5F.8010003-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-04-08 4:12 ` Darren Hart
2015-04-08 4:12 ` Darren Hart
[not found] ` <20150408041257.GC14618-JIrPihikzLEQaXB9iyTzyw@public.gmane.org>
2015-04-09 5:41 ` Shuah Khan [this message]
2015-04-09 5:41 ` Shuah Khan
[not found] ` <55261120.7040902-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-04-09 5:44 ` Darren Hart
2015-04-09 5:44 ` Darren Hart
2015-05-06 18:34 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55261120.7040902@osg.samsung.com \
--to=shuahkh-jph+aebz4p+uejcrhfaqsw@public.gmane.org \
--cc=dave-h16yJtLeMjHk1uMJSBkQmQ@public.gmane.org \
--cc=dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=kosaki.motohiro-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
--cc=mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.