From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 28/33] tools/libxl: Check if fdt_{first, next}_subnode are present in libfdt Date: Thu, 9 Apr 2015 14:59:52 +0100 Message-ID: <552685D8.5050200@citrix.com> References: <1426793399-6283-1-git-send-email-julien.grall@linaro.org> <1426793399-6283-29-git-send-email-julien.grall@linaro.org> <1427801755.2115.90.camel@citrix.com> <551A970A.9090202@linaro.org> <1427807893.2115.125.camel@citrix.com> <21798.28087.283088.975579@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YgD4l-0008OD-Fg for xen-devel@lists.xenproject.org; Thu, 09 Apr 2015 14:04:59 +0000 In-Reply-To: <21798.28087.283088.975579@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , Ian Campbell Cc: xen-devel@lists.xenproject.org, Julien Grall , tim@xen.org, Wei Liu , stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 09/04/15 13:16, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH v4 28/33] tools/libxl: Check if fdt_{first,next}_subnode are present in libfdt"): >> On Tue, 2015-03-31 at 13:46 +0100, Julien Grall wrote: >>> After speaking with Ian J. I will: >>> - Drop the GPL license from the header as we use the BSD one >>> - Add the libxl header license >>> - Specify in the commit message why we chose the BSD license. >> >> One downside to dropping the GPL bit is that any fixes which we get to >> this code cannot then easily be upstreamed. > > That's not the case. > > AIUI upstream's version of this file is BSD(2-clause) \union GPLv2. Right. > Our copy of the file will be BSD(2-clause) \union LGPLv2.1. > > We write LGPLv2.1 in it only to be clear that when anyone distributes > libxl_libfdt.c as part of libxl they must comply with the terms of the > LGPLv2.1 for the whole of libxl including libfdt. > > But the dual licence means that anyone who finds something in our > version that they want to send upstream, this is easy: they choose the > BSD(2-clause) option in the licence of our version, which (because > BSD(2-clause) is GPL*-compatible) grants the ability to distribute as > GPLv2. > > I think that leaving the GPL licence notice in is simply confusing. > The GPLv2 doesn't grant any additional permissions not covered by > BSD(2-clause), and the extra restrictions implied by GPLv2 are > irrelevant in the context of libxl because we are relying entirely on > the BSD(2-clause) option from upstream. > >> TBH I think it would be find to include both the GPL and BSD and to >> include a comment that within the context of libxl we have chosen BSD >> and so the overall license of the work remains LGPL. Ian may disagree >> though. > > I would say something like this: I will reuse the text below and add your signed-off-by for the license part. Regards, -- Julien Grall